`OptimisticLockingUtils` fails with `IllegalStateException` when constructing `OptimisticLockingFailureException` using flat composite primary keys

[pgehl]

We upgraded one of our reactive project using spring-data-cassandra to spring-boot 3.5.9.
This project:

• defines flat composite primary key using @PrimaryKeyColumn annotation.
• code did not change

Since the update, the integration test checking that OptimisticLockingFailureException are thrown for duplicate entry fail with (sensitive information replced by generic example information):

java.lang.IllegalStateException: Required identifier property not found for class com.example.cassandra.SampleCassandraData
	at org.springframework.data.mapping.PersistentEntity.getRequiredIdProperty(PersistentEntity.java:135)
	at org.springframework.data.cassandra.core.EntityOperations$MappedEntity.getIdentifier(EntityOperations.java:270)
	at org.springframework.data.cassandra.core.OptimisticLockingUtils.updateFailed(OptimisticLockingUtils.java:54)
	at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$doUpdateVersioned$16(ReactiveCassandraTemplate.java:638

The issue seems to be when OptimisticLockingUtils

public static OptimisticLockingFailureException updateFailed(EntityOperations.AdaptibleEntity<?> entity) {
	return new OptimisticLockingFailureException(String.format(
		"Failed to update versioned entity with id '%s' (version '%s') in table [%s]; Was the entity updated or deleted concurrently?",
		entity.getIdentifier(), entity.getVersion(), entity.getPersistentEntity().getTableName()));
	}

entity.getIdentifier() calls PersistentEntity.getRequiredIdProperty(). Our entity uses flat composite primary keys and does not have an idProperty.

Libraries and versions:

• spring-boot-starter-data-cassandra: 3.5.9
• spring-data-cassandra: 4.5.7

[mp911de]

Thanks for reaching out. Do you have a way to reproduce the issue, i.e. description of a reproducer? Looking at the stack trace, an update of a versioned entity seems failed.

[pgehl]

Due to NDA. I cannot share our project code.
Steps to reproduce:

1. Create an entity class with flat composite primary keys and a @Version annotated field
2. Create ReactiveCassandraRepository<ENTITY_CLASS_PREVIOUSLY_CREATED, MapId>
3. Create a @transaction annotated Service class
4. Save an instance of the entity with the service with version field null.
5. Save the exact same instance without incrementing the version
6. The following exception is thrown:

java.lang.IllegalStateException: Required identifier property not found for class ENTITY_CLASS_PREVIOUSLY_CREATED
	at org.springframework.data.mapping.PersistentEntity.getRequiredIdProperty(PersistentEntity.java:135)
	Suppressed: The stacktrace has been enhanced by Reactor, refer to additional information below: 
Assembly trace from producer [reactor.core.publisher.MonoHandleFuseable] :
	reactor.core.publisher.Mono.handle
org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$executeSave$33(ReactiveCassandraTemplate.java:780)
Error has been observed at the following site(s):
	*___________Mono.handle ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$executeSave$33(ReactiveCassandraTemplate.java:780)
	|_        Mono.doOnNext ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$executeSave$33(ReactiveCassandraTemplate.java:781)
	*______Mono.flatMapMany ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$executeSave$34(ReactiveCassandraTemplate.java:777)
	|_            Flux.next ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$executeSave$34(ReactiveCassandraTemplate.java:782)
	*____________Mono.defer ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.executeSave(ReactiveCassandraTemplate.java:773)
	|_                      ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.doInsertVersioned(ReactiveCassandraTemplate.java:589)
	|_                      ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.lambda$doInsert$13(ReactiveCassandraTemplate.java:579)
	*__________Mono.flatMap ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.doInsert(ReactiveCassandraTemplate.java:566)
	|_                      ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.insert(ReactiveCassandraTemplate.java:561)
	|_             Mono.map ⇢ at org.springframework.data.cassandra.core.ReactiveCassandraTemplate.insert(ReactiveCassandraTemplate.java:552)
	|_                      ⇢ at org.springframework.data.cassandra.repository.support.SimpleReactiveCassandraRepository.insert(SimpleReactiveCassandraRepository.java:246)
	|_                      ⇢ at org.springframework.data.repository.core.support.RepositoryMethodInvoker$ReactiveInvocationListenerDecorator.lambda$decorate$1(RepositoryMethodInvoker.java:222)
	*________Mono.usingWhen ⇢ at org.springframework.data.repository.core.support.RepositoryMethodInvoker$ReactiveInvocationListenerDecorator.decorate(RepositoryMethodInvoker.java:219)

Expected behaviour:
An OptimisticLockingFailureException should be thrown.

If it helps here is a simplified code of the test:

@Test
void when_create_duplicate_then_OptimisticLockingFailureException() {
	data.setAccountId(accountId);
	data.setVersion(null);

	assertThatNoException()
		.isThrownBy(() -> service.create(data)
								 .block());

	assertThatExceptionOfType(OptimisticLockingFailureException.class)
		.isThrownBy(() -> service.create(data)
								 .block());

}

This test fails with:

Expecting actual throwable to be an instance of:
  org.springframework.dao.OptimisticLockingFailureException
but was:
  java.lang.IllegalStateException: Required identifier property not found for class ENTITY_CLASS_PREVIOUSLY_CREATED
	at org.springframework.data.mapping.PersistentEntity.getRequiredIdProperty(PersistentEntity.java:135)

[mp911de]

Alright, thanks a lot. That's fixed now.