Deprecate MongoCustomConversions.BigDecimalRepresentation.STRING
#4957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Litvitski <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: enhancement
kssumin
pushed a commit
to kssumin/spring-data-mongodb
that referenced
this pull request
May 2, 2025
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references. When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax. Closes spring-projects#4957 Signed-off-by: kssumin <[email protected]>
kssumin
pushed a commit
to kssumin/spring-data-mongodb
that referenced
this pull request
May 2, 2025
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references. When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax. Closes spring-projects#4957 Signed-off-by: kssumin <[email protected]>
kssumin
pushed a commit
to kssumin/spring-data-mongodb
that referenced
this pull request
May 2, 2025
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references. When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax. Closes spring-projects#4957 Signed-off-by: kssumin <[email protected]>
|
Thank you for taking the time to look into this. Since it is a behaviour breaking change there are several test failures that need to be addressed before we can bring the change in. |
christophstrobl
added
the
status: waiting-for-feedback
mp911de
removed
the
status: waiting-for-feedback
mp911de
pushed a commit
that referenced
this pull request
Jul 15, 2025
Signed-off-by: Andrey Litvitski <[email protected]> Original pull request: #4957 Closes: #4920
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to use
BigIntegerstorage asDecimal128, so we should deprecate storage as strings.Fix: #4920