org.springframework.test.web.servlet.assertj.AbstractHttpServletResponseAssert#headers case sensitivity

[zeldigas]

In process of adopting MockMvcTester for controller testing I found that

assertThat(mockMvcTester.get("/....")...).headers().hasValue("cache-control", "public") //fails!
assertThat(mockMvcTester.get("/....")...).matches(MockMvcResultMatchers.header().string("cache-control", "public")); //passes!

Code inspection shows that HeaderResultMatchers works in case sensitive mode and it differs from MockMvcResultMatchers behavior.

Personally I think it is a bug as headers are considered case insensitve by semantics, but at minimum it should be documented if you consider it as a feature

[rstoyanchev]

The headers are stored in HttpHeaders, which supports case-insensitive names, but it doesn't work as expected through AssertJ. I see assertj/assertj#2159 for maps and that works.

Here HttpHeadersAssert#namesAssert wraps the Set returned from HttpHeaders#headerNames(), also case-insensitive, and that doesn't work.

HttpHeaders headers = new HttpHeaders();
headers.add("Header", "foo");

Set<String> set = headers.headerNames();
Assertions.assertThat(set.contains("header")).isTrue(); // succeeds
Assertions.assertThat(set).contains("header"); // fails

This looks like an issue to be fixed in AssertJ.

[rstoyanchev]

I created assertj/assertj#4157.

[rstoyanchev]

Re-opening to apply the workaround suggested in assertj/assertj#4157 (comment).