You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix references to invalid 'ackTimeout' property (#1015)
The docs has code examples using a consumer property named
`ackTimeout`. However, the actual property name is
`ackTimeoutMillis`. This updates those references.
Resolves#1010
Copy file name to clipboardExpand all lines: spring-pulsar-docs/src/main/antora/modules/ROOT/pages/reference/pulsar/message-consumption.adoc
+5-5
Original file line number
Diff line number
Diff line change
@@ -625,12 +625,12 @@ Apache Pulsar provides various native strategies for message redelivery and erro
625
625
By default, Pulsar consumers do not redeliver messages unless the consumer crashes, but you can change this behavior by setting an ack timeout on the Pulsar consumer.
626
626
If the ack timeout property has a value above zero and if the Pulsar consumer does not acknowledge a message within that timeout period, the message is redelivered.
627
627
628
-
When you use Spring for Apache Pulsar, you can set this property via a <<_consumer_customization_on_pulsarlistener,consumer customizer>> or with the native Pulsar `ackTimeout` property in the `properties` attribute of `@PulsarListener`:
628
+
When you use Spring for Apache Pulsar, you can set this property via a <<_consumer_customization_on_pulsarlistener,consumer customizer>> or with the native Pulsar `ackTimeoutMillis` property in the `properties` attribute of `@PulsarListener`:
@@ -743,7 +743,7 @@ This bean specifies a number of things, such as the max delivery (10, in this ca
743
743
If you do not specify a DLQ topic name, it defaults to `<topicname>-<subscriptionname>-DLQ` in Pulsar.
744
744
Next, we provide this bean name to `PulsarListener` by setting the `deadLetterPolicy` property.
745
745
Note that the `PulsarListener` has a subscription type of `Shared`, as the DLQ feature only works with shared subscriptions.
746
-
This code is primarily for demonstration purposes, so we provide an `ackTimeout` value of 1 second.
746
+
This code is primarily for demonstration purposes, so we provide an `ackTimeoutMillis` value of 1000.
747
747
The idea is that the code throws the exception and, if Pulsar does not receive an ack within 1 second, it does a retry.
748
748
If that cycle continues ten times (as that is our max redelivery count in the `DeadLetterPolicy`), the Pulsar consumer publishes the messages to the DLQ topic.
749
749
We have another `PulsarListener` that listens on the DLQ topic to receive data as it is published to the DLQ topic.
Copy file name to clipboardExpand all lines: spring-pulsar-docs/src/main/antora/modules/ROOT/pages/reference/reactive-pulsar/reactive-message-consumption.adoc
return b -> b.property("ackTimeoutMillis", "1000");
346
347
}
347
348
}
348
349
----
@@ -352,7 +353,7 @@ This bean specifies a number of things, such as the max delivery (10, in this ca
352
353
If you do not specify a DLQ topic name, it defaults to `<topicname>-<subscriptionname>-DLQ` in Pulsar.
353
354
Next, we provide this bean name to `ReactivePulsarListener` by setting the `deadLetterPolicy` property.
354
355
Note that the `ReactivePulsarListener` has a subscription type of `Shared`, as the DLQ feature only works with shared subscriptions.
355
-
This code is primarily for demonstration purposes, so we provide an `ackTimeout` value of 1 second.
356
+
This code is primarily for demonstration purposes, so we provide an `ackTimeoutMillis` value of 1000.
356
357
The idea is that the code throws the exception and, if Pulsar does not receive an ack within 1 second, it does a retry.
357
358
If that cycle continues ten times (as that is our max redelivery count in the `DeadLetterPolicy`), the Pulsar consumer publishes the messages to the DLQ topic.
358
359
We have another `ReactivePulsarListener` that listens on the DLQ topic to receive data as it is published to the DLQ topic.
0 commit comments