Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor in_JSON #249

Open
abma opened this issue Jan 31, 2018 · 2 comments
Open

refactor in_JSON #249

abma opened this issue Jan 31, 2018 · 2 comments
Labels
question

Comments

@abma
Copy link
Contributor

abma commented Jan 31, 2018

for more commands A LOT of code can be reused.

specific:

  • permissions
  • (optional) parameter parsing
  • actions?!
@abma
Copy link
Contributor Author

abma commented Jan 31, 2018

when doing this, the "old" commands can be removed: very likely all moderator / admin commands.

some of them are used by spads / sldb, so take care! (afaik GETUSERID i.e.)

@silentwings silentwings mentioned this issue Sep 15, 2018
Open
@silentwings
Copy link
Contributor

silentwings commented Sep 15, 2018 •
edited
Loading

It looks to me like status / battle status would be the best candidates for this, but it would add alot of overhead, for not much gain. Not sure if its a good idea.

This was referenced Nov 11, 2018
Closed
Open
@silentwings silentwings mentioned this issue Jan 18, 2020
Closed
@silentwings silentwings mentioned this issue Feb 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abma @silentwings