Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nature Header Improvements #667

Open
alexkilgour opened this issue Jan 25, 2022 · 3 comments
Open

Nature Header Improvements #667

alexkilgour opened this issue Jan 25, 2022 · 3 comments
Labels
bug Something isn't working enhancement New feature or request nature nature toolkit issue role: FED stale this issue is more than 30 days old

Comments

@alexkilgour
Copy link
Collaborator

alexkilgour commented Jan 25, 2022

Some improvements need to be made to the nature header component:

  • The template has significant differences from the one in use on oscar
  • Remove explicit dependency on global-expander by moving expander to the global-javascript
  • Can we remove the dependency on utility classes?
  • Relies on search component that only exists within Oscar - is this used anywhere else? can it just be merged into the header
  • Not sure the way keylines are handled works with a dynamic template. Needs investigation.
  • Logos currently linked from media.springernature.com. Is this the best way? should this live inside the component?
@alexkilgour alexkilgour added bug Something isn't working enhancement New feature or request nature nature toolkit issue role: FED labels Jan 25, 2022
@benjclark
Copy link
Contributor

benjclark commented Feb 11, 2022

Re the relationship with c-search... this needs quite a bit of thought.

c-search is used in various places on nature.com, including:

  • Nature Header search popup
  • Journal homepages where users can search the journal
  • Nature search page / search results page
  • Nature advanced search page

c-search provides some basic styling of form elements (buttons, inputs, labels, selects) as well as providing some flex layout styles.

Should these search forms just use Global Forms instead? Why does c-search need to exist?

Afterall, the places where we have implemented it all look fairly different:

Screenshot 2022-02-11 at 11 28 58

Screenshot 2022-02-11 at 11 28 08

Screenshot 2022-02-11 at 11 26 53

Screenshot 2022-02-11 at 11 26 11

This doesn't necessarily need to be resolved as part of this Nature Header issue. But we need to understand what we want to do long term for this and how it affects Nature Header and how we should deal with Nature Header's dependency on c-search at this time.

One of the current main issues here is that c-search only exists in Oscar which is problematic for any other project consuming Nature Header

@ricky-lau
Copy link
Contributor

One of the current main issues here is that c-search only exists in Oscar which is problematic for any other project consuming Nature Header

I'd like to take out the styles used in c-search and move them into nature-header to resolve this problem. If theres no objection then I'll start that soonish.

@sturobson
Copy link
Contributor

There has been no update on this issue for 30 days. It is now marked as "stale". If you think this issue is still relevant and needs attention then reply with an update. If there is no update in 14 days, this issue will be closed.

@sturobson sturobson added the stale this issue is more than 30 days old label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request nature nature toolkit issue role: FED stale this issue is more than 30 days old
Projects
None yet
Development

No branches or pull requests

4 participants