From 537556cb06ace1f22edcd5f1eafe2393029f9d50 Mon Sep 17 00:00:00 2001 From: Dane Springmeyer Date: Thu, 16 Oct 2014 20:57:48 -0700 Subject: [PATCH] improve code comments in travis config --- .travis.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 906d1bc..8e4f874 100644 --- a/.travis.yml +++ b/.travis.yml @@ -19,7 +19,7 @@ install: - ulimit -c before_script: - # Wet the core file limit to unlimited so they are generated upon crash + # Set the core file limit to unlimited so a core file is generated upon crash - ulimit -c unlimited -S script: @@ -29,13 +29,12 @@ script: - g++ -o test might_crash.cpp -g -O0 -DDEBUG # Run the program to prompt a crash # Note: we capture the return code of the program here and add - # `|| true` to ensure that travis continues so we can then get - # access to any core file the might exist + # `|| true` to ensure that travis continues past the crash - RESULT=$(./test > /dev/null)$? || true - if [[ ${RESULT} == 0 ]]; then echo "\\o/ our test worked without problems"; else echo "ruhroh test returned an errorcode of $RESULT"; fi; - # If the program returned and error code, now we check for a + # If the program returned an error code, now we check for a # core file in the current working directory and dump the backtrace out - for i in $(find ./ -maxdepth 1 -name 'core*' -print); do gdb $(pwd)/test core* -ex "thread apply all bt" -ex "set pagination 0" -batch; done; - # now we should present travis with the original error code - # so our logs cleanly stop with the original error code + # now we should present travis with the original + # error code so the run cleanly stops - if [[ ${RESULT} != 0 ]]; then exit $RESULT ; fi;