Repository navigation
Deprecate EOL Python; Add support for Python 3.11 - 3.14 - #62
boabdilperez wants to merge 5 commits into
Conversation
|
|
|
Please update reference screenshots |
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Thanks @boabdilperez ! Looks very good overall, just a few minor comments, all as suggestions, plus one slightly less minor but still easily addressable one (adding __init__.py to the data dirs instead of making it a namespace package).
Also, you could pick up the one remaining relevant change from PR #58 not already included here, either already or in my suggestions, namely adding pytest.ini to the MANIFEST.in.
Thanks!
|
|
||
| [options] | ||
| packages = find: | ||
| packages = find_namespace: |
There was a problem hiding this comment.
Instead of switching this to be namespace package, which can sometimes cause issues with tooling and isn't (at least not originally) designed for this situation, I would instead just put __init__.pys in the various data directories. Not that elegant either, I know, but we can probably cook up a better solution when we migrate to pyproject.toml project metadata and possibly a more modern build system, and maybe make the actual access to the package resources less hacky too.
Removing deprecated config identifying the project software license Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Applying all the batched suggestions for minor updates. Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
This pull request updates docrepr to drop support for all end-of-life versions of Python and enables support of all current versions of Python up to Python 3.14.
The bulk of the changes are in the setup and configuration files as well as the github actions workflow definitions. The Github actions changes bump version numbers to support the new Python versions and simplifying the test matrix now that all iterations of the testing support the same arguments.
setup.cfgpytest.iniandpyproject.tomlare all updated to support the new Python versions and bump more dependency versions to support the latest Python versions, especially aroundasync. The update of IPython to support the new Python version also included API changes in that library that required updating the signatures of some function calls, as well as a reference to an updated function call in the README doc.Finally any references to deprecated Python versions in the README or CONTRIBUTING docs were updated to use the new ones.
Something to note: The CI pipeline on this is definitely going to fail because github actions is going to use the test definitions from the master branch which is still configured to use the old pythons and dependencies.
AI Disclosure: Coding advice and help understanding the github actions API was provided by an LLM model. Claude Code, utilizing Anthropic's "Opus 5.5" model set to "extra high effort" is the configuration used. No LLM code ended up in the repo and no LLM prose was used in any commit message, this pull request, or comment.