Skip to content

Commit 4d61b0d

Browse files
author
lushenle
committed
Fix redundant rows.Close() calls in queryCode.tmpl
- Updated queryCode.tmpl to use defer for rows.Close() - Ensured rows.Close() is called only once - Improved resource management following Go best practices
1 parent 6b2ed20 commit 4d61b0d

File tree

244 files changed

+31
-1322
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

244 files changed

+31
-1322
lines changed

Diff for: ‎internal/codegen/golang/templates/stdlib/queryCode.tmpl

-3
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ func (q *Queries) {{.MethodName}}(ctx context.Context, {{ dbarg }} {{.Arg.Pair}}
5353
}
5454
items = append(items, {{.Ret.ReturnName}})
5555
}
56-
if err := rows.Close(); err != nil {
57-
return nil, err
58-
}
5956
if err := rows.Err(); err != nil {
6057
return nil, err
6158
}

Diff for: ‎internal/endtoend/testdata/any/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/array_in/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/array_text/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/array_text_join/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/between_args/mysql/go/query.sql.go

-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/between_args/sqlite/go/query.sql.go

-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/build_tags/postgresql/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/case_stmt_bool/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/case_text/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/cast_coalesce/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/cast_null/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/cast_param/sqlite/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/citext/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce/mysql/go/query.sql.go

-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce/postgresql/stdlib/go/query.sql.go

-18
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce/sqlite/go/query.sql.go

-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce_as/mysql/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce_as/postgresql/stdlib/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce_as/sqlite/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/coalesce_join/postgresql/go/query.sql.go

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: ‎internal/endtoend/testdata/comment_on/postgresql/stdlib/go/query.sql.go

-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)