Skip to content

Commit 2b1c135

Browse files
committed
fix html nesting error in map component
1 parent 14cbbaf commit 2b1c135

File tree

2 files changed

+39
-31
lines changed

2 files changed

+39
-31
lines changed

CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# CHANGELOG.md
22

3-
## 0.10.1
3+
## 0.10.2 (unreleased)
44

5+
- Fix a bug where the `map` component followed by another component would break the page layout.
6+
7+
## 0.10.1 (2023-08-27)
58
- Update the SQL parser, with multiple fixes. See https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md#0370-2023-08-22
69
- Display all parameters in the debug component (instead of only row-level parameters).
710
- Update dashmap for better file lookup performance.

sqlpage/templates/map.handlebars

+35-30
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,40 @@
11
<div class="card my-3">
2-
<div class="card-body">
3-
<div class="d-flex">
4-
<h3 class="card-title">{{title}}</h3>
2+
<div class="card-body">
3+
<h3 class="card-title">{{title}}</h3>
4+
<div
5+
class="leaflet"
6+
style="height: {{default height 350}}px;"
7+
data-center="{{default latitude 48}},{{default longitude 3}}"
8+
data-zoom="{{default zoom 5}}"
9+
>
10+
<div class="d-flex justify-content-center h-100 align-items-center">
11+
<div
12+
class="spinner-border"
13+
role="status"
14+
style="width: 3rem; height: 3rem;"
15+
>
16+
<span class="visually-hidden">Loading map...</span>
517
</div>
6-
<div class="leaflet" style="height: {{default height 350}}px;"
7-
data-center="{{default latitude 48}},{{default longitude 3}}"
8-
data-zoom="{{default zoom 5}}"
9-
>
10-
<div class="d-flex justify-content-center h-100 align-items-center">
11-
<div class="spinner-border" role="status" style="width: 3rem; height: 3rem;">
12-
<span class="visually-hidden">Loading map...</span>
13-
</div>
14-
<div class="d-none" hidden>
15-
{{~#each_row~}}
16-
<div class="marker" data-coords="{{latitude}},{{longitude}}">
17-
<h3>
18-
{{~#if link~}}
19-
<a href="{{link}}">{{title}}</a>
20-
{{~else~}}
21-
{{title}}
22-
{{~/if~}}
23-
</h3>
24-
<div>
25-
{{~#if description}}<p>{{description}}</p>{{/if~}}
26-
{{~#if description_md~}}
27-
{{{markdown description_md}}}
28-
{{~/if~}}
29-
</div>
30-
</div>
31-
{{~/each_row~}}
32-
</div>
18+
<div class="d-none" hidden>
19+
{{~#each_row~}}
20+
<div class="marker" data-coords="{{latitude}},{{longitude}}">
21+
<h3>
22+
{{~#if link~}}
23+
<a href="{{link}}">{{title}}</a>
24+
{{~else~}}
25+
{{title}}
26+
{{~/if~}}
27+
</h3>
28+
<div>
29+
{{~#if description}}<p>{{description}}</p>{{/if~}}
30+
{{~#if description_md~}}
31+
{{{markdown description_md}}}
32+
{{~/if~}}
33+
</div>
34+
</div>
35+
{{~/each_row~}}
3336
</div>
37+
</div>
3438
</div>
39+
</div>
3540
</div>

0 commit comments

Comments
 (0)