Merge pull request #612 from erizocosmico/feature/uast-errors

*: make UAST functions fail on connection errors

Author: ajnavarro

Gopkg.lock

@@ -54,15 +54,15 @@
 
 [[constraint]]
   name = "gopkg.in/bblfsh/client-go.v3"
-  version = "3.0.0"
+  version = "3.1.0"
 
 [[override]]
   name = "gopkg.in/bblfsh/sdk.v1"
   version = "1.16.0"
 
 [[constraint]]
   name = "gopkg.in/bblfsh/sdk.v2"
-  version = "2.3.0"
+  version = "2.7.0"
 
 [[constraint]]
   name = "github.com/uber/jaeger-client-go"

Gopkg.toml

@@ -12,6 +12,7 @@ import (
 	lru "github.com/hashicorp/golang-lru"
 	"github.com/sirupsen/logrus"
 	bblfsh "gopkg.in/bblfsh/client-go.v3"
+	derrors "gopkg.in/bblfsh/sdk.v2/driver/errors"
 	"gopkg.in/bblfsh/sdk.v2/uast"
 	"gopkg.in/bblfsh/sdk.v2/uast/nodes"
 
@@ -203,12 +204,11 @@ func (u *uastFunc) getUAST(
 		var err error
 		node, err = getUASTFromBblfsh(ctx, blob, lang, xpath, mode)
 		if err != nil {
-			if ErrParseBlob.Is(err) {
+			if ErrParseBlob.Is(err) || derrors.ErrSyntax.Is(err) {
 				return nil, nil
 			}
 
-			logrus.WithField("err", err).Error("unable to get UAST from bblfsh")
-			return nil, nil
+			return nil, err
 		}
 
 		uastCache.Add(key, node)

internal/function/uast.go

@@ -177,7 +177,7 @@ func (s *Session) BblfshClient() (*BblfshClient, error) {
 	var attempts, totalAttempts int
 	for {
 		if attempts > bblfshMaxAttempts || totalAttempts > 3*bblfshMaxAttempts {
-			return nil, ErrBblfshConnection.New()
+			return nil, ErrBblfshConnection.New("max attempts exceeded")
 		}
 
 		switch s.bblfshClient.GetState() {
@@ -190,7 +190,7 @@ func (s *Session) BblfshClient() (*BblfshClient, error) {
 			time.Sleep(100 * time.Millisecond)
 		default:
 			if err := s.bblfshClient.Close(); err != nil {
-				return nil, err
+				return nil, ErrBblfshConnection.New(err)
 			}
 
 			logrus.Debug("bblfsh connection is closed, opening a new one")
@@ -223,10 +223,10 @@ func connectToBblfsh(endpoint string) (*bblfsh.Client, error) {
 	client, err := bblfsh.NewClient(endpoint)
 	if err != nil {
 		if err == context.DeadlineExceeded {
-			return nil, ErrBblfshConnection.New()
+			return nil, ErrBblfshConnection.New(err)
 		}
 
-		return nil, err
+		return nil, ErrBblfshConnection.New(err)
 	}
 
 	return client, nil
@@ -252,7 +252,7 @@ var ErrInvalidGitbaseSession = errors.NewKind("expecting gitbase session, but re
 var ErrInvalidContext = errors.NewKind("invalid context received: %v")
 
 // ErrBblfshConnection is returned when it's impossible to connect to bblfsh.
-var ErrBblfshConnection = errors.NewKind("unable to establish a connection with the bblfsh server")
+var ErrBblfshConnection = errors.NewKind("unable to establish a connection with the bblfsh server: %s")
 
 func shouldSkipErrors(ctx *sql.Context) bool {
 	s, err := getSession(ctx)