Fix/convert to bool (#907)

Fix/convert to bool

Author: ajnavarro

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Panic on query using EXPLODE ([#755](https://github.com/src-d/go-mysql-server/issues/755))
 - Fixed error iterating over non ready repositories ([src-d/go-borges#54](https://github.com/src-d/go-borges/pull/54))
+- Error saying value could not be converted to bool.
 
 ## [0.22.0-rc1] - 2019-06-21
 
@@ -24,10 +25,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-- function: correctly transform up explode nodes ([#757](https://github.com/src-d/go-mysql-server/pull/757)) 
+- function: correctly transform up explode nodes ([#757](https://github.com/src-d/go-mysql-server/pull/757))
 - git libraries bare or non bare format is automatically detected ([#897](https://github.com/src-d/gitbase/pull/897))
 - Fix bug that created multiple object cache with incorrect size ([#898](https://github.com/src-d/gitbase/pull/898))
-- sql/expression: handle null values in arithmetic expressions ([#760](https://github.com/src-d/go-mysql-server/pull/760)) 
+- sql/expression: handle null values in arithmetic expressions ([#760](https://github.com/src-d/go-mysql-server/pull/760))
 
 ## [0.22.0-beta1] - 2019-06-20
 
@@ -43,7 +44,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-- function: correctly transform up explode nodes ([#757](https://github.com/src-d/go-mysql-server/pull/757)) 
+- function: correctly transform up explode nodes ([#757](https://github.com/src-d/go-mysql-server/pull/757))
 
 ## [0.21.0] - 2019-06-20
 

go.mod

@@ -17,7 +17,7 @@ require (
 	github.com/src-d/go-borges v0.0.0-20190624135448-6ee47472d565
 	github.com/src-d/go-git v4.7.0+incompatible
 	github.com/src-d/go-git-fixtures v3.5.1-0.20190605154830-57f3972b0248+incompatible
-	github.com/src-d/go-mysql-server v0.4.1-0.20190624094722-bc2334894674
+	github.com/src-d/go-mysql-server v0.4.1-0.20190624135918-d9b20c8d6b72
 	github.com/stretchr/testify v1.3.0
 	github.com/uber-go/atomic v1.4.0 // indirect
 	github.com/uber/jaeger-client-go v2.16.0+incompatible

go.sum

@@ -225,8 +225,8 @@ github.com/src-d/go-git v4.7.0+incompatible h1:IYSSnbAHeKmsfbQFi9ozbid+KNh0bKjlo
 github.com/src-d/go-git v4.7.0+incompatible/go.mod h1:1bQciz+hn0jzPQNsYj0hDFZHLJBdV7gXE2mWhC7EkFk=
 github.com/src-d/go-git-fixtures v3.5.1-0.20190605154830-57f3972b0248+incompatible h1:A5bKevhs9C//Nh8QV0J+1KphEaIa25cDe1DTs/yPxDI=
 github.com/src-d/go-git-fixtures v3.5.1-0.20190605154830-57f3972b0248+incompatible/go.mod h1:XcIQp7L+k0pgfTqfbaTKj3kxlBv8kYOKZ/tKNXbZFLg=
-github.com/src-d/go-mysql-server v0.4.1-0.20190624094722-bc2334894674 h1:pzziN+eE0Z4p6gTOuOpgId5v47Y7DVwJ/y5KPFCqcsM=
-github.com/src-d/go-mysql-server v0.4.1-0.20190624094722-bc2334894674/go.mod h1:GO8SmBnN9LcKSXy6DYuBbqKtJvrRnHsBrlXvlVOX+NM=
+github.com/src-d/go-mysql-server v0.4.1-0.20190624135918-d9b20c8d6b72 h1:mdRElTdq3BLiI+olROiWjf4oCmOzWW9PzHYhLMVM5QA=
+github.com/src-d/go-mysql-server v0.4.1-0.20190624135918-d9b20c8d6b72/go.mod h1:GO8SmBnN9LcKSXy6DYuBbqKtJvrRnHsBrlXvlVOX+NM=
 github.com/src-d/go-oniguruma v1.0.0 h1:JDk5PUAjreGsGAKLsoDLNmrsaryjJ5RqT3h+Si6aw/E=
 github.com/src-d/go-oniguruma v1.0.0/go.mod h1:chVbff8kcVtmrhxtZ3yBVLLquXbzCS6DrxQaAK/CeqM=
 github.com/src-d/go-oniguruma v1.1.0 h1:EG+Nm5n2JqWUaCjtM0NtutPxU7ZN5Tp50GWrrV8bTww=

integration_test.go

@@ -496,6 +496,19 @@ func TestIntegration(t *testing.T) {
 				{"lordran.local", int64(1)},
 			},
 		},
+		{
+			`
+			SELECT file_path
+			FROM commit_files
+			NATURAL JOIN refs
+			WHERE ref_name = 'HEAD'
+			AND LANGUAGE(file_path) = 'Go';
+			`,
+			[]sql.Row{
+				{"go/example.go"},
+				{"vendor/foo.go"},
+			},
+		},
 	}
 
 	var pid uint64

squash_iterator.go

@@ -3486,17 +3486,7 @@ func (i *squashCommitFileBlobsIter) Close() error {
 }
 
 func evalFilters(ctx *sql.Context, row sql.Row, filters sql.Expression) (bool, error) {
-	v, err := filters.Eval(ctx, row)
-	if err != nil {
-		return false, err
-	}
-
-	v, err = sql.Boolean.Convert(v)
-	if err != nil {
-		return false, err
-	}
-
-	return v.(bool), nil
+	return sql.EvaluateCondition(ctx, filters, row)
 }
 
 var errInvalidCommit = errors.NewKind("invalid commit of type: %T")