Better to implement Describe without variadics... That is for the CLI!

Signed-off-by: Eduardo Lezcano <[email protected]>

Author: Eduardo Lezcano

repository.go

@@ -1270,55 +1270,50 @@ func (d *Describe) String() string {
 		d.Dirty)
 }
 
-func (r *Repository) Describe(options *DescribeOptions, hashes ...*plumbing.Hash) ([]Describe, error) {
+// Describe just like the `git describe` command will return a Describe struct for the hash passed.
+// Describe struct implements String interface so it can be easily printed out.
+func (r *Repository) Describe(options *DescribeOptions, hash *plumbing.Hash) (*Describe, error) {
+
+	// Fetch the reference log
+	commitIterator, err := r.Log(&LogOptions{
+		From:  *hash,
+		Order: LogOrderCommitterTime,
+	})
+	if err != nil {
+		return nil, err
+	}
 
-	var describes []Describe
+	// Tag map for rapid (?) query
+	tagIterator, err := r.Tags()
+	if err != nil {
+		return nil, err
+	}
+	tags := make(map[plumbing.Hash]*plumbing.Reference)
+	tagIterator.ForEach(func(t *plumbing.Reference) error {
+		tags[t.Hash()] = t
+		return nil
+	})
 
-	for _, hash := range hashes {
 
-		// Fetch the reference log
-		commitIterator, err := r.Log(&LogOptions{
-			From:  *hash,
-			Order: LogOrderCommitterTime,
-		})
-		if err != nil {
-			return nil, err
+	// Search the tag
+	var tag *plumbing.Reference
+	var count int
+	err = commitIterator.ForEach(func(c *object.Commit) error {
+		if t, ok := tags[c.Hash]; ok {
+			tag = t
 		}
-
-		// Tag map for rapid (?) query
-		tagIterator, err := r.Tags()
-		if err != nil {
-			return nil, err
+		if tag != nil {
+			return storer.ErrStop
 		}
-		tags := make(map[plumbing.Hash]*plumbing.Reference)
-		tagIterator.ForEach(func(t *plumbing.Reference) error {
-			tags[t.Hash()] = t
-			return nil
-		})
-
-
-		// Search the tag
-		var tag *plumbing.Reference
-		var count int
-		err = commitIterator.ForEach(func(c *object.Commit) error {
-			if t, ok := tags[c.Hash]; ok {
-				tag = t
-			}
-			if tag != nil {
-				return storer.ErrStop
-			}
-			count++
-			return nil
-		})
-
-		describes = append(describes, Describe{
-			hash,
-			tag,
-			count,
-			options.Dirty,
-		})
+		count++
+		return nil
+	})
 
-	}
+	return &Describe{
+		hash,
+		tag,
+		count,
+		options.Dirty,
+	}, nil
 
-	return describes, nil
 }