Skip to content

Commit 803bb53

Browse files
committed
refactor: for numbers -> use toString instead of show (idea of flip111 from purescript-halogen#13)
1 parent d375930 commit 803bb53

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Halogen/VDom/DOM/StringRenderer.purs

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import Halogen.VDom.DOM.Prop (Prop(..), PropValue)
66
import Data.Array as A
77
import Foreign (unsafeToForeign, typeOf)
88
import Data.Maybe (Maybe(..))
9+
import Data.Number.Format as Data.Number.Format
910
import Data.String as S
1011
import Data.Set as Set
1112
import Halogen.VDom.StringRenderer as VSR
@@ -44,7 +45,7 @@ propNameToAttrName = case _ of
4445
renderProperty String PropValue Maybe String
4546
renderProperty name prop = case typeOf (unsafeToForeign prop) of
4647
"string" → renderAttr name' $ (unsafeCoerce PropValue String) prop
47-
"number" → renderAttr name' $ show ((unsafeCoerce PropValue Number) prop)
48+
"number" → renderAttr name' $ Data.Number.Format.toString ((unsafeCoerce PropValue Number) prop)
4849
"boolean"
4950
if ((unsafeCoerce :: PropValue -> Boolean) prop)
5051
then Just $ escape name'

0 commit comments

Comments
 (0)