Skip to content

Breaks when more than one ReactRouterPrompt is used #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karol-majewski opened this issue Feb 24, 2023 · 4 comments · May be fixed by #96
Closed

Breaks when more than one ReactRouterPrompt is used #90

karol-majewski opened this issue Feb 24, 2023 · 4 comments · May be fixed by #96
Assignees

Comments

@karol-majewski
Copy link

Reproduction:

https://codesandbox.io/s/react-router-prompt-example-react-router-6-7-forked-ink76d

@sshyam-gupta sshyam-gupta self-assigned this Feb 27, 2023
@sshyam-gupta
Copy link
Owner

sshyam-gupta commented Apr 15, 2023

@karol-majewski I am trying to reproduce it here https://codesandbox.io/s/react-router-prompt-example-react-router-6-7-forked-j91ukk?file=/src/App.js but it works.
I observed that you have set when to false.
Can you please confirm if that was the issue or anything else you are trying to explain?

--
Edit:
Are you trying to use the Component in same page, can you share your use-case?

@sshyam-gupta sshyam-gupta linked a pull request Apr 15, 2023 that will close this issue
@karol-majewski
Copy link
Author

My apologies for being imprecise. I overlooked the fact that dependencies in my CodeSandbox had no fixed versions.

I suspect you have figured it out, but this is the issue I was getting when using [email protected]:

CleanShot 2023-04-16 at 22 26 57@2x

@sshyam-gupta
Copy link
Owner

sshyam-gupta commented Apr 20, 2023

Yes @karol-majewski you reported it right there and is fixed in v0.5.2
#88 (comment)
Thank you.

@karol-majewski
Copy link
Author

Excellent! Thank you 🙇🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants