Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent Field Names #23

Open
sammysmallman opened this issue Aug 2, 2022 · 2 comments · May be fixed by #24
Open

Consistent Field Names #23

sammysmallman opened this issue Aug 2, 2022 · 2 comments · May be fixed by #24

Comments

@sammysmallman
Copy link

sammysmallman commented Aug 2, 2022 •
edited
Loading

Fields duplicated across parameters should use the same "name" value.
For example DEVICE_INFO contains the personality index and dmx start address, but uses different names for those fields rather than what is used in DMX_PERSONALITY and DMX_START_ADDRESS.
@sammysmallman sammysmallman linked a pull request Aug 2, 2022 that will close this issue
Open
@ssilverman
Copy link
Owner

This is an issue with the specification and not the DEVICE_INFO.json file.

@sammysmallman
Copy link
Author

I agree this is an issue with the specification and inconsistent verbiage. But we can't let that roll into code. The name is used to uniquely identify one parameters field from another and in this situation a user of the schemas may not only be trying to keep their localisation files DRY but using the unique id's to correlate duplicate fields across parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide consistent field names across parameters sammysmallman/rdm-schema
2 participants
@ssilverman @sammysmallman