-
Notifications
You must be signed in to change notification settings - Fork 30
Enabling asset indexing #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rch into unique_asset_names
…ch into unique_asset_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me and definitely useful.
This isn't your responsibility to create here, but it would be great to create some unit tests for the ItemSerializer
and the CollectionSerializer
.
Approved, but I'll leave this for Jon to review and merge
Added a ticket to track unit tests here: #425 |
**Description:** There are a number of extensions that include extra fields within an Item's assets. It would be useful to allow users to filter items based on these fields. Mapping assets from an Object to a Array of Objects prevents "mapping explosion" from asset keys without needing to disable indexing on the assets. It does have some search implications. See first "note" [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html). **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [x] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog
This reverts commit 8974c38.
This reverts commit e24498f.
**Description:** There are a number of extensions that include extra fields within an Item's assets. It would be useful to allow users to filter items based on these fields. Mapping assets from an Object to a Array of Objects prevents "mapping explosion" from asset keys without needing to disable indexing on the assets. It does have some search implications. See first "note" [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/array.html). **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [x] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog
Description:
There are a number of extensions that include extra fields within an Item's assets. It would be useful to allow users to filter items based on these fields.
Mapping assets from an Object to a Array of Objects prevents "mapping explosion" from asset keys without needing to disable indexing on the assets.
It does have some search implications. See first "note" here.
PR Checklist:
pre-commit run --all-files
)make test
)