Patch/add titles in links (#805)

vincentsarago · web-flow · commit c3e1cd09e14b · 2025-03-04T09:50:43.000+01:00
* defined links title in landing page

* update changelog

* fix
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+### Added
+
+- titles in `Landing` page links
+
 ### Changed
 
 - remove `child` links (`collections`) in landing page response
diff --git a/stac_fastapi/api/tests/test_app.py b/stac_fastapi/api/tests/test_app.py
@@ -188,7 +188,9 @@ def get_search(
         )
 
     assert landing.status_code == 200, landing.text
-    assert "Queryables" in [link.get("title") for link in landing.json()["links"]]
+    assert "Queryables available for this Catalog" in [
+        link.get("title") for link in landing.json()["links"]
+    ]
     assert get_search.status_code == 200, get_search.text
     assert post_search.status_code == 200, post_search.text
 
@@ -221,7 +223,9 @@ def get_search(
         )
 
     assert landing.status_code == 200, landing.text
-    assert "Queryables" in [link.get("title") for link in landing.json()["links"]]
+    assert "Queryables available for this Catalog" in [
+        link.get("title") for link in landing.json()["links"]
+    ]
     assert get_search.status_code == 200, get_search.text
     assert post_search.status_code == 200, post_search.text
 
diff --git a/stac_fastapi/api/tests/test_app_prefix.py b/stac_fastapi/api/tests/test_app_prefix.py
@@ -64,6 +64,7 @@ def test_api_prefix(TestCoreClient, prefix):
 
         link_tests = [
             ("root", "application/json", "/"),
+            ("self", "application/json", "/"),
             ("conformance", "application/json", "/conformance"),
             ("data", "application/json", "/collections"),
             ("search", "application/geo+json", "/search"),
@@ -126,6 +127,7 @@ def test_async_api_prefix(AsyncTestCoreClient, prefix):
 
         link_tests = [
             ("root", "application/json", "/"),
+            ("self", "application/json", "/"),
             ("conformance", "application/json", "/conformance"),
             ("data", "application/json", "/collections"),
             ("search", "application/geo+json", "/search"),
@@ -190,6 +192,7 @@ def test_api_prefix_with_root_path(TestCoreClient, prefix):
 
         link_tests = [
             ("root", "application/json", "/"),
+            ("self", "application/json", "/"),
             ("conformance", "application/json", "/conformance"),
             ("data", "application/json", "/collections"),
             ("search", "application/geo+json", "/search"),
diff --git a/stac_fastapi/types/stac_fastapi/types/core.py b/stac_fastapi/types/stac_fastapi/types/core.py
@@ -289,16 +289,19 @@ def _landing_page(
                 {
                     "rel": Relations.self.value,
                     "type": MimeTypes.json.value,
+                    "title": "This document",
                     "href": base_url,
                 },
                 {
                     "rel": Relations.root.value,
                     "type": MimeTypes.json.value,
+                    "title": "Root",
                     "href": base_url,
                 },
                 {
                     "rel": Relations.data.value,
                     "type": MimeTypes.json.value,
+                    "title": "Collections available for this Catalog",
                     "href": urljoin(base_url, "collections"),
                 },
                 {
@@ -310,14 +313,14 @@ def _landing_page(
                 {
                     "rel": Relations.search.value,
                     "type": MimeTypes.geojson.value,
-                    "title": "STAC search",
+                    "title": "STAC search [GET]",
                     "href": urljoin(base_url, "search"),
                     "method": "GET",
                 },
                 {
                     "rel": Relations.search.value,
                     "type": MimeTypes.geojson.value,
-                    "title": "STAC search",
+                    "title": "STAC search [POST]",
                     "href": urljoin(base_url, "search"),
                     "method": "POST",
                 },
@@ -391,7 +394,7 @@ def landing_page(self, **kwargs) -> stac.LandingPage:
                 {
                     "rel": Relations.queryables.value,
                     "type": MimeTypes.jsonschema.value,
-                    "title": "Queryables",
+                    "title": "Queryables available for this Catalog",
                     "href": urljoin(base_url, "queryables"),
                 }
             )
@@ -601,7 +604,7 @@ async def landing_page(self, **kwargs) -> stac.LandingPage:
                 {
                     "rel": Relations.queryables.value,
                     "type": MimeTypes.jsonschema.value,
-                    "title": "Queryables",
+                    "title": "Queryables available for this Catalog",
                     "href": urljoin(base_url, "queryables"),
                     "method": "GET",
                 }

Original file line number	Diff line number	Diff line change
`@@ -289,16 +289,19 @@ def _landing_page(`
`289`	`289`	`{`
`290`	`290`	`"rel": Relations.self.value,`
`291`	`291`	`"type": MimeTypes.json.value,`
	`292`	`+ "title": "This document",`
`292`	`293`	`"href": base_url,`
`293`	`294`	`},`
`294`	`295`	`{`
`295`	`296`	`"rel": Relations.root.value,`
`296`	`297`	`"type": MimeTypes.json.value,`
	`298`	`+ "title": "Root",`
`297`	`299`	`"href": base_url,`
`298`	`300`	`},`
`299`	`301`	`{`
`300`	`302`	`"rel": Relations.data.value,`
`301`	`303`	`"type": MimeTypes.json.value,`
	`304`	`+ "title": "Collections available for this Catalog",`
`302`	`305`	`"href": urljoin(base_url, "collections"),`
`303`	`306`	`},`
`304`	`307`	`{`
`@@ -310,14 +313,14 @@ def _landing_page(`
`310`	`313`	`{`
`311`	`314`	`"rel": Relations.search.value,`
`312`	`315`	`"type": MimeTypes.geojson.value,`
`313`		`- "title": "STAC search",`
	`316`	`+ "title": "STAC search [GET]",`
`314`	`317`	`"href": urljoin(base_url, "search"),`
`315`	`318`	`"method": "GET",`
`316`	`319`	`},`
`317`	`320`	`{`
`318`	`321`	`"rel": Relations.search.value,`
`319`	`322`	`"type": MimeTypes.geojson.value,`
`320`		`- "title": "STAC search",`
	`323`	`+ "title": "STAC search [POST]",`
`321`	`324`	`"href": urljoin(base_url, "search"),`
`322`	`325`	`"method": "POST",`
`323`	`326`	`},`
`@@ -391,7 +394,7 @@ def landing_page(self, **kwargs) -> stac.LandingPage:`
`391`	`394`	`{`
`392`	`395`	`"rel": Relations.queryables.value,`
`393`	`396`	`"type": MimeTypes.jsonschema.value,`
`394`		`- "title": "Queryables",`
	`397`	`+ "title": "Queryables available for this Catalog",`
`395`	`398`	`"href": urljoin(base_url, "queryables"),`
`396`	`399`	`}`
`397`	`400`	`)`
`@@ -601,7 +604,7 @@ async def landing_page(self, **kwargs) -> stac.LandingPage:`
`601`	`604`	`{`
`602`	`605`	`"rel": Relations.queryables.value,`
`603`	`606`	`"type": MimeTypes.jsonschema.value,`
`604`		`- "title": "Queryables",`
	`607`	`+ "title": "Queryables available for this Catalog",`
`605`	`608`	`"href": urljoin(base_url, "queryables"),`
`606`	`609`	`"method": "GET",`
`607`	`610`	`}`