Test for validating an invalid catalog #20

Author: m-mohr

tests/cli.test.js

@@ -1,12 +1,13 @@
 const app = require('../index');
 
-let consoleErrSpy, consoleInfSpy, consoleLogSpy, mockExit;
+let consoleErrSpy, consoleWarnSpy, consoleInfSpy, consoleLogSpy, mockExit;
 const initString = 'STAC Node Validator v1.1.0';
 
 beforeEach(() => {
 	mockExit = jest.spyOn(process, 'exit').mockImplementation();
 	consoleInfSpy = jest.spyOn(console, 'info').mockImplementation();
 	consoleLogSpy = jest.spyOn(console, 'log').mockImplementation();
+	consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation();
 	consoleErrSpy = jest.spyOn(console, 'error').mockImplementation();
 });
 
@@ -29,15 +30,17 @@ describe('Running without parameters or configuration', () => {
 	});
 });
 
-describe('Running with a configured simple catalog', () => {
+describe('Running with a configured valid catalog', () => {
+	let files = ['tests/catalog.json'];
+
 	it('Should return exit code 0', async () => {
-		await app({files: ['tests/catalog.json']});
+		await app({files});
 
 		expect(mockExit).toHaveBeenCalledWith(0);
 	});
 
 	it('Should print informational messages', async () => {
-		await app({files: ['tests/catalog.json']});
+		await app({files});
 
 		expect(consoleLogSpy.mock.calls[0][0]).toContain(initString);
 		expect(consoleLogSpy.mock.calls[1][0]).toContain('tests/catalog.json');
@@ -46,8 +49,47 @@ describe('Running with a configured simple catalog', () => {
 		expect(consoleInfSpy.mock.calls[2][0]).toContain('Invalid: 0');
 	});
 
-	it('Should not print an error message', async () => {
-		await app({files: ['tests/catalog.json']});
+	it('Should not print a critical error message', async () => {
+		await app({files});
+
+		expect(consoleErrSpy).not.toHaveBeenCalled();
+	});
+});
+
+describe('Running with a configured invalid catalog', () => {
+	let files = ['tests/invalid-catalog.json'];
+	it('Should return exit code 1', async () => {
+		await app({files});
+
+		expect(mockExit).toHaveBeenCalledWith(1);
+	});
+
+	it('Should print informational messages', async () => {
+		await app({files});
+
+		expect(consoleLogSpy.mock.calls[0][0]).toContain(initString);
+		expect(consoleLogSpy.mock.calls[1][0]).toContain('tests/invalid-catalog.json');
+		expect(consoleInfSpy.mock.calls[0][0]).toContain('Files: 1');
+		expect(consoleInfSpy.mock.calls[1][0]).toContain('Valid: 0');
+		expect(consoleInfSpy.mock.calls[2][0]).toContain('Invalid: 1');
+	});
+
+	it('Should print validation warnings', async () => {
+		await app({files});
+
+		console.log(consoleWarnSpy);
+
+		expect(consoleWarnSpy.mock.calls[0][0]).toEqual([{
+			"instancePath": "",
+			"keyword": "required",
+			"message": "must have required property 'links'",
+			"params": {"missingProperty": "links"},
+			"schemaPath": "#/required"
+		}]);
+	});
+
+	it('Should not print a critical error message', async () => {
+		await app({files});
 
 		expect(consoleErrSpy).not.toHaveBeenCalled();
 	});

tests/invalid-catalog.json

@@ -0,0 +1,7 @@
+{
+  "stac_version": "1.0.0",
+  "id": "example",
+  "type": "Catalog",
+  "title": "Example Catalog",
+  "description": "A minimal example for tests"
+}