Skip to content

Validator hangs with other $schema than draft-07 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fmigneault opened this issue Nov 6, 2024 · 3 comments · May be fixed by #81
Open

Validator hangs with other $schema than draft-07 #80

fmigneault opened this issue Nov 6, 2024 · 3 comments · May be fixed by #81
Milestone
future

Comments

@fmigneault
Copy link

fmigneault commented Nov 6, 2024 •
edited
Loading

Using this schema: https://github.com/stac-extensions/mlm/blob/fix-mlm-artefact/json-schema/schema.json

Which employs "$schema": "https://json-schema.org/draft/2019-09/schema#"

Running stac-node-validator hangs on this example: https://github.com/stac-extensions/mlm/blob/fix-mlm-artefact/examples/item_bands_expression.json
Example: https://github.com/stac-extensions/mlm/actions/runs/11696331893/job/32573240886?pr=52

Simply changing back to "$schema": "http://json-schema.org/draft-07/schema#" directly validates without issue.

However, I need 2019-09 in this case because of "unevaluatedProperties": false feature.
@fmigneault fmigneault changed the title Validator hands with other $schema than draft-07 Validator hangs with other $schema than draft-07 Nov 6, 2024
@fmigneault fmigneault mentioned this issue Nov 6, 2024
Merged
10 tasks
@fmigneault
Copy link
Author

fmigneault commented Nov 6, 2024 •
edited
Loading

@m-mohr I guess the ajv reference must be updated, as per https://ajv.js.org/json-schema.html#draft-2019-09 ?

edit: confirmed with local test, will create a PR

@fmigneault fmigneault linked a pull request Nov 6, 2024 that will close this issue
Draft
@fmigneault
Copy link
Author

Found a workaround (stac-extensions/mlm#59).
Given that, 2019-09 support is not needed anymore.

@m-mohr m-mohr reopened this Nov 7, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented Nov 7, 2024

I'll reopen because it's nevertheless an issue that should be fixed. A software should never hang...

@m-mohr m-mohr added the bug Something isn't working label Nov 7, 2024
@m-mohr m-mohr removed the bug Something isn't working label Mar 14, 2025
@m-mohr m-mohr modified the milestones: 2.0.0, future Mar 14, 2025
@vprivat-ads vprivat-ads mentioned this issue Mar 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
future
Development

Successfully merging a pull request may close this issue.

allow JSON schema 2019-09 as well as draft-07 crim-ca/stac-node-validator
2 participants
@m-mohr @fmigneault