tests: Verify invalid schema handling #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
force-pushed
the
tests/verify-invalid-schema-handling
branch
from
e33a44a to
e03ebac
Compare
Collaborator
|
It looks like there's something wrong with this PR, it contains a lot of additional commits?! |
l0b0
force-pushed
the
tests/verify-invalid-schema-handling
branch
from
e03ebac to
b961664
Compare
Collaborator
Author
|
My bad, I rebased onto origin/master rather than upstream/master. |
Collaborator
|
Thanks. There are some conflicts that need to be solved. |
This does *not* test the error message printed, for two reasons: 1. The original message comes from Ajv, which is outside the scope of this test. 2. The message sent to `console.error` when inspecting the spy in the test, '--- https://example.org/invalid-schema.json: anyOf value must be ["array"]', is slightly different from the one actually printed to standard error when running the command, '--- https://example.org/invalid-schema.json: schema is invalid: data/anyOf must be array'.
l0b0
force-pushed
the
tests/verify-invalid-schema-handling
branch
from
b961664 to
15d87be
Compare
l0b0
force-pushed
the
tests/verify-invalid-schema-handling
branch
from
15d87be to
1b37c55
Compare
l0b0
added a commit
to linz/stac-node-validator
that referenced
this pull request
Sep 7, 2022
* tests: Verify invalid schema handling This does *not* test the error message printed, for two reasons: 1. The original message comes from Ajv, which is outside the scope of this test. 2. The message sent to `console.error` when inspecting the spy in the test, '--- https://example.org/invalid-schema.json: anyOf value must be ["array"]', is slightly different from the one actually printed to standard error when running the command, '--- https://example.org/invalid-schema.json: schema is invalid: data/anyOf must be array'. * tests: Bump coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not test the error message printed, for two reasons:
this test.
console.errorwhen inspecting the spy in thetest, '--- https://example.org/invalid-schema.json: anyOf value must
be ["array"]', is slightly different from the one actually printed to
standard error when running the command, '---
https://example.org/invalid-schema.json: schema is invalid:
data/anyOf must be array'.
Closes #20.