Better comments regarding lud16 domain handling in wallet forms

Author: ekzyis

wallets/client/components/form/hooks.js

@@ -104,7 +104,7 @@ export function useProtocolForm (protocol) {
         const { lud16 } = parseNwcUrl(nwcSendFormState.config.url)
         if (lud16?.split('@')[1] === lud16Domain) value = lud16
       }
-      // remove domain part since we will append it automatically if lud16Domain is set
+      // remove domain part since we will append it automatically on submit if lud16Domain is set
       if (lud16Domain && value) {
         value = value.split('@')[0]
       }
@@ -120,6 +120,7 @@ export function useProtocolForm (protocol) {
   if (lud16Domain) {
     schema = schema.transform(({ address, ...rest }) => {
       return {
+        // append domain part to pass validation on submit
         address: address ? `${address}@${lud16Domain}` : '',
         ...rest
       }

wallets/client/components/form/index.js

@@ -100,6 +100,8 @@ function WalletProtocolForm () {
 
   // create a copy of values to avoid mutating the original
   const onSubmit = useCallback(async ({ ...values }) => {
+    // the schema transformation already does this to pass validation on submit
+    // so it would be better to use the transformed values instead of manually appending the domain part again here
     const lud16Domain = walletLud16Domain(wallet.name)
     if (values.address && lud16Domain) {
       values.address = `${values.address}@${lud16Domain}`