Skip to content

Nested new comments are not highlighted #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
Soxasora opened this issue Apr 23, 2025 · 1 comment · May be fixed by #2133
Open
1 task done

Nested new comments are not highlighted #2127

Soxasora opened this issue Apr 23, 2025 · 1 comment · May be fixed by #2133
Assignees
Labels
enhancement improvements to existing features ui/ux

Comments

@Soxasora
Copy link
Member

Soxasora commented Apr 23, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When a post has a new comment, we show a blue mark on the number of comments the post has. We continue this UI/UX pattern by highlighting the new comments once we enter the comment section.

But nested comments are hidden behind a "view all n replies" so until we navigate to them we can't see any highlight.

I lived this moment of confusion searching the new comments everywhere only to then realize that the view all n replies number was growing

Screenshots

New comments on ItemInfo
Image

View all n replies not highlighted
Image

Steps To Reproduce

  1. Click on a post that has new comments
  2. Discover that there are no new comments highlighted
  3. If you click on view all n replies, it finally shows the new comments highlighted.

Expected behavior

"view all n replies" should be highlighted as well, to indicate that there are new nested comments.

Logs

No response

Device information

No response

Additional context

No response

@Soxasora Soxasora added enhancement improvements to existing features ui/ux labels Apr 23, 2025
@huumn
Copy link
Member

huumn commented Apr 24, 2025

Nice catch!

@Soxasora Soxasora self-assigned this Apr 25, 2025
@Soxasora Soxasora linked a pull request Apr 25, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features ui/ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants