Skip to content

Commit cb03c85

Browse files
authored
Merge pull request #19 from stackhpc/missing-grub-default-cmdline
Handle missing GRUB_CMDLINE_LINUX_DEFAULT variable
2 parents 888807a + e3620af commit cb03c85

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

roles/grubcmdline/tasks/main.yml

+17-2
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,25 @@
2525
ansible.builtin.set_fact:
2626
grub_cmdline_linux_default: >-
2727
{{ grub_result.content | b64decode | regex_search('^GRUB_CMDLINE_LINUX_DEFAULT.*$', multiline=True) | regex_replace('^GRUB_CMDLINE_LINUX_DEFAULT="(.*)"$', '\1') }}
28-
- name: Display GRUB_CMDLINE_DEFAULT
28+
29+
- name: Set fact containing GRUB_CMDLINE_LINUX
30+
ansible.builtin.set_fact:
31+
grub_cmdline_linux: >-
32+
{{ grub_result.content | b64decode | regex_search('^GRUB_CMDLINE_LINUX=.*$', multiline=True) | regex_replace('^GRUB_CMDLINE_LINUX="(.*)"$', '\1') }}
33+
34+
- name: Display GRUB_CMDLINE_LINUX_DEFAULT
2935
ansible.builtin.debug:
3036
var: grub_cmdline_linux_default
3137

38+
- name: Display GRUB_CMDLINE_LINUX
39+
ansible.builtin.debug:
40+
var: grub_cmdline_linux
41+
42+
- name: Initialise GRUB_CMDLINE_LINUX_DEFAULT if unset
43+
ansible.builtin.set_fact:
44+
grub_cmdline_linux_default: "{{ grub_cmdline_linux }}"
45+
when: grub_cmdline_linux_default == 'None'
46+
3247
- name: Determine which parameters need removing
3348
# We use a regex here so you can remove parameters regardless of their value, e.g to remove iommu=on you
3449
# could use the regex: ^iommu=
@@ -43,7 +58,7 @@
4358
ansible.builtin.set_fact:
4459
grub_cmdline_linux_new: "{{ grub_cmdline_linux_default.split() | difference(grub_cmdline_linux_remove) + kernel_cmdline | select() }}"
4560

46-
- name: Display newly computed GRUB_CMDLINE_DEFAULT
61+
- name: Display newly computed GRUB_CMDLINE_LINUX_DEFAULT
4762
ansible.builtin.debug:
4863
var: grub_cmdline_linux_new
4964

0 commit comments

Comments
 (0)