fixing linting issues.

Author: grzegorzkoper

roles/systemd_networkd/defaults/main.yml

@@ -3,7 +3,6 @@
 systemd_networkd_link: {}
 systemd_networkd_netdev: {}
 systemd_networkd_network: {}
-
 systemd_networkd_apply_config: false
 systemd_networkd_enable_resolved: true
 systemd_networkd_symlink_resolv_conf: true

roles/systemd_networkd/handlers/main.yml

@@ -1,9 +1,9 @@
 ---
 # handlers for ansible-role-systemd-networkd
 
-- name: restart systemd-networkd
+- name: Restart systemd-networkd
   become: true
-  service:
+  ansible.builtin.service:
     name: systemd-networkd
     state: restarted
   when: systemd_networkd_apply_config

roles/systemd_networkd/meta/main.yml

@@ -2,23 +2,23 @@
 galaxy_info:
   role_name: systemd_networkd
   namespace: stackhpc
-  author: "Anthony Ruhier & StackHPC Ltd"
+  author: Anthony Ruhier & StackHPC Ltd
   description: Configures systemd-networkd
   license: BSD
   min_ansible_version: "2.5"
   platforms:
-  - name: EL
-    versions:
-    - all
-  - name: Fedora
-    versions:
-    - all
-  - name: Ubuntu
-    versions:
-    - all
-  - name: Debian
-    versions:
-    - all
+    - name: EL
+      versions:
+        - all
+    - name: Fedora
+      versions:
+        - all
+    - name: Ubuntu
+      versions:
+        - all
+    - name: Debian
+      versions:
+        - all
   galaxy_tags:
-  - networking
+    - networking
 dependencies: []

roles/systemd_networkd/tasks/cleanup.yml

@@ -4,8 +4,8 @@
 
 - name: Find unexpected systemd-networkd configuration files
   become: true
-  find:
-    paths: "/etc/systemd/network"
+  ansible.builtin.find:
+    paths: /etc/systemd/network
     patterns: "{{ systemd_networkd_cleanup_patterns }}"
     use_regex: "{{ systemd_networkd_cleanup_patterns_use_regex | bool }}"
   register: networkd_files
@@ -17,8 +17,8 @@
       - "{{ systemd_networkd_link.keys() | map('regex_replace', '^(.*)$', '\\1.link') | list }}"
       - "{{ systemd_networkd_netdev.keys() | map('regex_replace', '^(.*)$', '\\1.netdev') | list }}"
       - "{{ systemd_networkd_network.keys() | map('regex_replace', '^(.*)$', '\\1.network') | list }}"
-  file:
-    path: "/etc/systemd/network/{{ item }}"
+  ansible.builtin.file:
+    path: /etc/systemd/network/{{ item }}
     state: absent
   loop: "{{ networkd_files.files | map(attribute='path') | map('basename') | difference(expected_files | flatten) | list }}"
   notify:

roles/systemd_networkd/tasks/config.yml

@@ -1,5 +1,4 @@
 ---
-
 - name: Ensure systemd-networkd configuration files exist
   become: true
   vars:
@@ -12,12 +11,12 @@
         files: "{{ systemd_networkd_netdev | dict2items }}"
       - type: network
         files: "{{ systemd_networkd_network | dict2items }}"
-  template:
-    src: "systemd_networkd_config.j2"
-    dest: "/etc/systemd/network/{{ item.1.key }}.{{ item.0.type }}"
+  ansible.builtin.template:
+    src: systemd_networkd_config.j2
+    dest: /etc/systemd/network/{{ item.1.key }}.{{ item.0.type }}
     owner: root
     group: systemd-network
-    mode: 0640
+    mode: "0640"
   loop: "{{ query('subelements', all_files, 'files') }}"
   loop_control:
     label: "{{ item.0.type }} - {{ item.1.key }}"

roles/systemd_networkd/tasks/main.yml

@@ -1,8 +1,10 @@
 ---
-- import_tasks: cleanup.yml
+- name: Import cleanup tasks
+  ansible.builtin.import_tasks: cleanup.yml
   when: systemd_networkd_cleanup | bool
 
-- import_tasks: config.yml
+- name: Import config tasks
+  ansible.builtin.import_tasks: config.yml
 
 - name: Make sure systemd-resolved is installed
   become: true
@@ -13,28 +15,28 @@
     - ansible_facts.distribution | lower == 'debian'
     - ansible_facts.distribution_major_version >= '12'
 
-- name: enable systemd-networkd
+- name: Enable systemd-networkd
   become: true
-  service:
+  ansible.builtin.service:
     name: systemd-networkd
-    enabled: yes
+    enabled: true
   when: systemd_networkd_network or systemd_networkd_link or systemd_networkd_netdev
 
-- name: start and enable systemd-resolved
+- name: Start and enable systemd-resolved
   become: true
-  service:
+  ansible.builtin.service:
     name: systemd-resolved
-    enabled: yes
+    enabled: true
     state: started
   when: systemd_networkd_enable_resolved
 
-- name: replace /etc/resolv.conf with a symlink to the systemd-resolved stub
+- name: Replace /etc/resolv.conf with a symlink to the systemd-resolved stub
   become: true
-  file:
+  ansible.builtin.file:
     path: /etc/resolv.conf
     src: /run/systemd/resolve/stub-resolv.conf
     state: link
-    force: yes
+    force: true
   when: systemd_networkd_symlink_resolv_conf
 
 # vim: set ts=2 sw=2: