fixes generation of manifests via kubebuilder (#2924)

* fixes generation of manifests via kubebuilder

currently when you run a task operator-manifests, it will change the
clusterrole when it shouldn't. the reason for this is because a var
block was added directly below the kubebuilder comment markers that
generate the permissions for the clusterrole. kubebuilder therefore
ignored the markers because they thought the comments were related to
the var block itself. this commit moves the var block to be away from
the kubebuilder markers to remove interference

Signed-off-by: Chris Burns <[email protected]>

* removes duplicate var block

Signed-off-by: Chris Burns <[email protected]>

---------

Signed-off-by: Chris Burns <[email protected]>
Co-authored-by: Chris Burns <[email protected]>

Author: eleftherias

cmd/thv-operator/controllers/virtualmcpserver_controller.go

@@ -66,6 +66,10 @@ type VirtualMCPServerReconciler struct {
 	PlatformDetector *ctrlutil.SharedPlatformDetector
 }
 
+var (
+	envVarSanitizeRegex = regexp.MustCompile(`[^A-Z0-9_]`)
+)
+
 // +kubebuilder:rbac:groups=toolhive.stacklok.dev,resources=virtualmcpservers,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=toolhive.stacklok.dev,resources=virtualmcpservers/status,verbs=get;update;patch
 // +kubebuilder:rbac:groups=toolhive.stacklok.dev,resources=mcpgroups,verbs=get;list;watch
@@ -81,9 +85,6 @@ type VirtualMCPServerReconciler struct {
 // +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch
 // +kubebuilder:rbac:groups=apps,resources=deployments,verbs=create;delete;get;list;patch;update;watch
 // +kubebuilder:rbac:groups="",resources=serviceaccounts,verbs=create;delete;get;list;patch;update;watch
-var (
-	envVarSanitizeRegex = regexp.MustCompile(`[^A-Z0-9_]`)
-)
 
 // Reconcile is part of the main kubernetes reconciliation loop which aims to
 // move the current state of the cluster closer to the desired state.