return err when version conversion fails (#1212)

Author: daynewlee

api/v1/orchestratorscan/service.go

@@ -119,14 +119,14 @@ func (s *serviceImpl) GetIstioVulnerabilities(_ context.Context, req *v1.GetIsti
 	if req.GetIstioVersion() == "" {
 		return nil, errors.New("Can't get vulnerabilities for empty version.")
 	}
-	version, err := convert.TruncateVersion(req.GetIstioVersion())
+	v, err := convert.TruncateVersion(req.GetIstioVersion())
 	if err != nil {
-		log.Warnf("Unable to convert Istio version of %s - %v. Skipping...", version, err)
-		return nil, nil
+		log.Warnf("Unable to convert Istio version: %v. Skipping...", err)
+		return nil, err
 	}
 
-	vulns := s.istioCache.GetVulnsByVersion(version)
-	converted := convert.IstioVulnerabilities(version, vulns)
+	vulns := s.istioCache.GetVulnsByVersion(v)
+	converted := convert.IstioVulnerabilities(v, vulns)
 
 	resp.Vulnerabilities = filterInvalidVulns(converted)