Do not include a read only call in early return tests and create a sep test for this case

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jacinta-stacks

stackslib/src/chainstate/tests/consensus.rs

@@ -1893,3 +1893,19 @@ fn problematic_supertype_list() {
     deploy_epochs: &StacksEpochId::since(StacksEpochId::Epoch20),
     );
 }
+
+#[test]
+/// Test that a read-only function call can be included in a block without issue.
+/// The fn also shows that a non-response is handled without issue with the testing framework.
+fn read_only_transaction_block() {
+    contract_call_consensus_test!(
+        contract_name: "read-only-call",
+        contract_code: "
+            (define-read-only (trigger)
+                (some u1)
+            )
+        ",
+        function_name: "trigger",
+        function_args: &[],
+    );
+}

stackslib/src/chainstate/tests/early_return_tests.rs

@@ -88,7 +88,7 @@ fn native_try_ret_err_ccall() {
     contract_call_consensus_test!(
         contract_name: "unwrap-err",
         contract_code: "
-            (define-read-only (trigger (resp (response uint uint)))
+            (define-public (trigger (resp (response uint uint)))
                 (begin
                     (try! resp)
                     (ok u1)
@@ -124,12 +124,19 @@ fn native_try_ret_none_ccall() {
     contract_call_consensus_test!(
         contract_name: "unwrap-try-opt",
         contract_code: "
-            (define-read-only (trigger (opt (optional bool)))
+            (define-read-only (trigger-ro (opt (optional bool)))
                 (begin
                     (try! opt)
                     (some true)
                 )
             )
+            (define-public (trigger (opt (optional bool)))
+                (match (trigger-ro opt)
+                    value
+                    (ok u1)
+                    (err u404)
+                )
+            )
         ",
         function_name: "trigger",
         function_args: &[ClarityValue::none()],
@@ -190,7 +197,7 @@ fn native_unwrap_or_ret_none_ccall() {
     contract_call_consensus_test!(
         contract_name: "unwrap-opt",
         contract_code: "
-            (define-read-only (trigger (opt (optional bool)))
+            (define-public (trigger (opt (optional bool)))
                 (begin
                     (unwrap! opt (err false))
                     (ok true)