-
Notifications
You must be signed in to change notification settings - Fork 724
Closed
Labels
choreNecessary but less impactful tasks such as cleanup or reorgNecessary but less impactful tasks such as cleanup or reorg
Description
Remove the -c, --coverage option from clarity-cli and the underlying EvalHook/CoverageReporter implementation from the Clarity VM.
Why
- Clarinet already does this better (
clarinet test --coverage) TheEvalHooktrait adds an extra lifetime parameter ('hooks) that propagates throughGlobalContext,Environment, andOwnedEnvironment- Clarinet is the standard tool for Clarity development
- Less lines of code we don't need to maintain
What to remove
clarity/src/vm/coverage.rs(delete)EvalHooktrait and hook calls inclarity/src/vm/mod.rs'hookslifetime from context structs inclarity/src/vm/contexts.rs- Coverage params from
clarity-cli(lib.rs, main.rs, README.md)
If we ever need VM hooks again, the pattern is simple and in git history.
Metadata
Metadata
Assignees
Labels
choreNecessary but less impactful tasks such as cleanup or reorgNecessary but less impactful tasks such as cleanup or reorg
Type
Projects
Status
Status: ✅ Done