Skip to content
This repository was archived by the owner on Jun 15, 2022. It is now read-only.

line-height issue #3

Open
ghost opened this issue Aug 12, 2018 · 4 comments
Open

line-height issue #3

ghost opened this issue Aug 12, 2018 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented Aug 12, 2018

The lack of declaration of line-height for #editor makes text really really hard to read. It should have been 1.2em at least. You can try to play with the value to see what I mean. It gives the text air to breath, right now it personally causes me headache because it's way too concentrated.

@moughxyz
Copy link
Member

Hmm maybe. In any case, custom changes like this aren't the best long term solution. Best to build solutions that instead allow everyone to get what they want. A custom theme builder in the future would be a better solution.

@ghost
Copy link
Author

ghost commented Aug 13, 2018

@mobitar I think this is a detail that will make usability better for everyone, it's not a major overhaul that would better wait for the proper framework to be handled...

@moughxyz
Copy link
Member

Feel free to submit a PR, I don't think I'll get a chance to visit this repo any time soon.

@TheodoreChu
Copy link
Contributor

TheodoreChu commented Jun 12, 2020

The <textarea> in #editor-container doesn't inherit the line-height of #simple-markdown. I'll fix this in the TypeScript conversion. I think 1.5em is the minimum for accessibility according to W3: https://www.w3.org/TR/2008/REC-WCAG20-20081211/#visual-audio-contrast-visual-presentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants