Skip to content

Commit 97c2917

Browse files
committed
0.2.9 RC 1
1 parent 8f87f3e commit 97c2917

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from setuptools import setup
66
from pathlib import Path
77

8-
AK_VERSION = '0.2.8'
8+
AK_VERSION = '0.2.9'
99

1010
def get_long_description() -> str:
1111
return '''The ArrayKit library provides utilities for creating and transforming NumPy arrays, implementing performance-critical StaticFrame operations as Python C extensions.

src/_arraykit.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -1924,7 +1924,7 @@ AK_CPL_to_array_bytes(AK_CodePointLine* cpl, PyArray_Descr* dtype)
19241924
return array;
19251925
}
19261926

1927-
// If we cannot directly convert bytes to values in a pre-loadsed array, we can create a bytes or unicode array and then use PyArray_CastToType to use numpy to interpret it as a new a array and handle conversions. Note that we can use bytes for a smaller memory load if we are confident that the values are not unicode. This is a safe assumption for complext. Fore datetim64, we have to use Unicode to get errors on malformed inputs: using bytes causes a seg fault with these interfaces (the same is not observed with astyping a byte array in Python).
1927+
// If we cannot directly convert bytes to values in a pre-loaded array, we can create a bytes or unicode array and then use PyArray_CastToType to use numpy to interpret it as a new a array and handle conversions. Note that we can use bytes for a smaller memory load if we are confident that the values are not unicode. This is a safe assumption for complex. For datetime64, we have to use Unicode to get errors on malformed inputs: using bytes causes a seg fault with these interfaces (the same is not observed with astyping a byte array in Python).
19281928
static inline PyObject*
19291929
AK_CPL_to_array_via_cast(AK_CodePointLine* cpl,
19301930
PyArray_Descr* dtype,
@@ -1944,6 +1944,7 @@ AK_CPL_to_array_via_cast(AK_CodePointLine* cpl,
19441944
else if (type_inter == NPY_UNICODE) {
19451945
array_inter = AK_CPL_to_array_unicode(cpl, dtype_inter);
19461946
}
1947+
// else array_inter is NULL and we exit without an exception set
19471948

19481949
if (array_inter == NULL) {
19491950
Py_DECREF(dtype); // dtype_inter ref already stolen

0 commit comments

Comments
 (0)