Skip to content

Commit e3b0973

Browse files
committed
Merge composer deps
Instead of building 2 separate composer deps, just build one with everything and remove dev deps when needed.
1 parent 014e08a commit e3b0973

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

dev/flake.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@
417417
TMPDIR="$(realpath ./tmp)"
418418
mkdir -p "$TMPDIR"
419419
echo 'SELECT version();' | mysql -h 127.0.0.1 --port="${toString dbPort}" --user="${dbUserName}" --password="${dbUserPass}" "${dbName}"
420-
cp -r --no-preserve=mode ${staticDeployPkgs.composerVendorDev}/. .
420+
cp -r --no-preserve=mode ${staticDeployPkgs.composerVendor}/. .
421421
cp -r ${staticDeployLib.staticDeploySrc}/. .
422422
composer dump-autoload
423423
WORDPRESS_DIR="$(realpath ./data/wordpress1)"

flake.nix

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,6 @@
3030
rel == "composer.json" || rel == "composer.lock";
3131
};
3232
composerVendor = php.mkComposerVendor (finalAttrs: {
33-
composerNoDev = true;
34-
pname = "${name}-composer-deps";
35-
version = "1.0.0";
36-
src = composerSrc;
37-
vendorHash = "sha256-FAX0tSuV5Gw0Xs4AYOiYqot8hWpdDzGpLxTwzlcFgz0=";
38-
});
39-
composerVendorDev = php.mkComposerVendor (finalAttrs: {
4033
composerNoDev = false;
4134
pname = "${name}-composer-deps-dev";
4235
version = "1.0.0";
@@ -88,16 +81,14 @@
8881
''
8982
export PLUGIN_DIR="$TMPDIR/${name}"
9083
mkdir -p "$PLUGIN_DIR"
91-
cp -r --no-preserve=mode "${composerVendorDev}/vendor" .
84+
cp -r --no-preserve=mode "${composerVendor}/vendor" .
9285
cp -r --no-preserve=mode "${staticDeploySrc}"/* .
9386
9487
# Lock certain constants and run rector to remove dead code
9588
cp ${constantsFile} constants.php
9689
just rector
9790
98-
rm -rf vendor
99-
cp -r --no-preserve=mode "${composerVendor}/vendor" .
100-
composer dump-autoload --no-dev --optimize
91+
composer install --no-cache --no-dev --optimize-autoloader
10192
10293
mkdir -p "$out"
10394
cp -r composer.json readme.txt src static-deploy.php uninstall.php vendor views "$out"
@@ -142,7 +133,7 @@
142133
export PLUGIN_DIR="$TMPDIR/${name}"
143134
mkdir -p "$PLUGIN_DIR"
144135
cd "$PLUGIN_DIR"
145-
cp -a "${composerVendorDev}/vendor" .
136+
cp -a "${composerVendor}/vendor" .
146137
cp -r --no-preserve=mode "$src"/* .
147138
just _check_no_test
148139
'';
@@ -152,7 +143,7 @@
152143
checks = { inherit staticDeployCheck; };
153144
lib = { inherit staticDeploySrc; };
154145
packages = {
155-
inherit composerVendorDev composerVendor staticDeploy;
146+
inherit composerVendor staticDeploy;
156147
plugin = staticDeploy;
157148
pluginGitHubSrc = staticDeployGitHubSrc;
158149
pluginWpOrg = staticDeployWpOrg;

0 commit comments

Comments
 (0)