receipt fix

Author: chirag-parmar

nimbus_verified_proxy/rpc/receipts.nim

@@ -0,0 +1,95 @@
+# nimbus_verified_proxy
+# Copyright (c) 2022-2024 Status Research & Development GmbH
+# Licensed and distributed under either of
+#   * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
+#   * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
+# at your option. This file may not be copied, modified, or distributed except according to those terms.
+
+{.push raises: [].}
+
+import
+  std/sequtils,
+  stint,
+  results,
+  chronicles,
+  eth/common/[base_rlp, transactions_rlp, receipts_rlp, hashes_rlp],
+  ../../execution_chain/beacon/web3_eth_conv,
+  eth/common/addresses,
+  eth/common/eth_types_rlp,
+  eth/trie/[hexary, ordered_trie, db, trie_defs],
+  json_rpc/[rpcproxy, rpcserver, rpcclient],
+  web3/[primitives, eth_api_types, eth_api],
+  ../types,
+  ./blocks,
+  ../header_store
+
+export results, stint, hashes_rlp, accounts_rlp, eth_api_types
+
+template rpcClient(vp: VerifiedRpcProxy): RpcClient =
+  vp.proxy.getClient()
+
+template toLog(lg: LogObject): Log = 
+  Log(
+    address: lg.address,
+    topics: lg.topics,
+    data: lg.data
+  )
+
+proc toLogs(logs: openArray[LogObject]): seq[Log] =
+  result = map(logs, proc(x: LogObject): Log = toLog(x))
+
+proc toReceipt(rec: ReceiptObject): Receipt =
+  let isHash = if rec.status.isSome: false
+               else: true
+
+  var status = false 
+  if rec.status.isSome:
+    if rec.status.get() == 1.Quantity:
+      status = true
+
+  return Receipt(
+    hash: rec.transactionHash,
+    isHash: isHash,
+    status: status, 
+    cumulativeGasUsed: rec.cumulativeGasUsed.GasInt,
+    logs: toLogs(rec.logs),
+    logsBloom: rec.logsBloom,
+    receiptType: rec.`type`.get(0.Web3Quantity).ReceiptType
+  )
+
+proc toReceipts(recs: openArray[ReceiptObject]): seq[Receipt] =
+  for r in recs:
+    result.add(toReceipt(r))
+
+proc getReceiptsByBlockTag*(
+    vp: VerifiedRpcProxy, blockTag: BlockTag
+): Future[seq[ReceiptObject]] {.async: (raises: [ValueError, CatchableError]).} =
+
+  let 
+    header = await vp.getHeaderByTag(blockTag)
+    rxs = await vp.rpcClient.eth_getBlockReceipts(blockTag)
+
+  if rxs.isSome():
+    if orderedTrieRoot(toReceipts(rxs.get())) != header.receiptsRoot:
+      raise newException(ValueError, "downloaded receipts do not evaluate to the receipts root of the block")
+  else:
+    raise newException(ValueError, "error downloading the receipts")
+
+  return rxs.get()
+
+proc getReceiptsByBlockHash*(
+    vp: VerifiedRpcProxy, blockHash: Hash32
+): Future[seq[ReceiptObject]] {.async: (raises: [ValueError, CatchableError]).} =
+
+  let 
+    header = await vp.getHeaderByHash(blockHash)
+    blockTag = BlockTag(RtBlockIdentifier(kind: bidNumber, number: Quantity(header.number)))
+    rxs = await vp.rpcClient.eth_getBlockReceipts(blockTag)
+
+  if rxs.isSome():
+    if orderedTrieRoot(toReceipts(rxs.get())) != header.receiptsRoot:
+      raise newException(ValueError, "downloaded receipts do not evaluate to the receipts root of the block")
+  else:
+    raise newException(ValueError, "error downloading the receipts")
+
+  return rxs.get()

nimbus_verified_proxy/rpc/rpc_eth_api.nim

@@ -25,7 +25,8 @@ import
   ../types,
   ./blocks,
   ./accounts,
-  ./transactions
+  ./transactions,
+  ./receipts
 
 logScope:
   topics = "verified_proxy"
@@ -115,6 +116,26 @@ proc installEthApiHandlers*(vp: VerifiedRpcProxy) =
 
     return tx
 
+  # TODO: this method should also support block hashes. For that, the client call should also suupport block hashes
+  vp.proxy.rpc("eth_getBlockReceipts") do(
+    blockTag: BlockTag
+  ) -> Opt[seq[ReceiptObject]]:
+    let rxs = await vp.getReceiptsByBlockTag(blockTag)
+    return Opt.some(rxs)
+
+  vp.proxy.rpc("eth_getTransactionReceipt") do(
+    txHash: Hash32
+  ) -> ReceiptObject:
+    let 
+      rx = await vp.rpcClient.eth_getTransactionReceipt(txHash)
+      rxs = await vp.getReceiptsByBlockHash(rx.blockHash)
+
+    for r in rxs:
+      if r.transactionHash == txHash:
+        return r
+
+    raise newException(ValueError, "receipt couldn't be verified")
+
   # eth_blockNumber - get latest tag from header store
   vp.proxy.rpc("eth_blockNumber") do() -> Quantity:
     # Returns the number of the most recent block seen by the light client.

nimbus_verified_proxy/rpc/transactions.nim

@@ -73,35 +73,6 @@ proc checkTxHash*(txObj: TransactionObject, txHash: Hash32): bool =
 
   return true
 
-template toLog(lg: LogObject): Log = 
-  Log(
-    address: lg.address,
-    topics: lg.topics,
-    data: lg.data
-  )
-
-proc toLogs(logs: openArray[LogObject]): seq[Log] =
-  result = map(logs, proc(x: LogObject): Log = toLog(x))
-
-proc toReceipt(rec: ReceiptObject): Receipt =
-  let isHash = if rec.status.isSome: false
-               else: true
-
-  var status = false 
-  if rec.status.isSome:
-    if rec.status.get() == 1.Quantity:
-      status = true
-
-  return Receipt(
-    hash: rec.transactionHash,
-    isHash: isHash,
-    status: status, 
-    cumulativeGasUsed: rec.cumulativeGasUsed.GasInt,
-    logs: toLogs(rec.logs),
-    logsBloom: rec.logsBloom,
-    receiptType: rec.`type`.get(0.Web3Quantity).ReceiptType
-  )
-
 proc verifyTransactions*(
     txRoot: Hash32,
     transactions: seq[TxOrHash],