Skip to content

Run all EEST engine tests, not just ones in static folder #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2025
Merged

Run all EEST engine tests, not just ones in static folder #3846

merged 3 commits into from
Nov 28, 2025

Conversation

@bhartnett
Copy link
Contributor

@bhartnett bhartnett commented Nov 27, 2025

No description provided.

bhartnett
bhartnett commented Nov 27, 2025
View reviewed changes
scripts/eest_ci_cache.sh

mkdir -p "${dest_dir}/engine_tests"
mv "${dest_dir}/blockchain_tests_engine/static/state_tests/"* "${dest_dir}/engine_tests" 2>/dev/null || true
rm -rf "${dest_dir}/blockchain_tests_engine"
Copy link
Contributor Author

@bhartnett bhartnett Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was deleting all the other tests not in the static folder and effectively reducing the number of tests which are run.

@tersec
Copy link
Contributor

tersec commented Nov 27, 2025

linux-amd64 from https://github.com/status-im/nimbus-eth1/actions/runs/19742848975/job/56570712949?pr=3846

eest_devnet: blockchain_tests ....................................................................................................................................................................................................................................................................................................................................................................... (21.6s)
[Summary] 3188 tests run (169.8s): 3188 OK, 0 FAILED, 0 SKIPPED
/usr/bin/ld: final link failed: No space left on device
collect2: error: ld returned 1 exit status
Error: execution of an external program failed: 'g++  @eest_engine_test_linkerArgs.txt'

@bhartnett
Copy link
Contributor Author

bhartnett commented Nov 28, 2025

linux-amd64 from https://github.com/status-im/nimbus-eth1/actions/runs/19742848975/job/56570712949?pr=3846

eest_devnet: blockchain_tests ....................................................................................................................................................................................................................................................................................................................................................................... (21.6s)
[Summary] 3188 tests run (169.8s): 3188 OK, 0 FAILED, 0 SKIPPED
/usr/bin/ld: final link failed: No space left on device
collect2: error: ld returned 1 exit status
Error: execution of an external program failed: 'g++  @eest_engine_test_linkerArgs.txt'

Not sure why this is failing. My changes here shouldn't have increased the disk usage significantly. Is there some caches on the runners that need to be cleaned up?

@bhartnett
Copy link
Contributor Author

bhartnett commented Nov 28, 2025

linux-amd64 from https://github.com/status-im/nimbus-eth1/actions/runs/19742848975/job/56570712949?pr=3846

eest_devnet: blockchain_tests ....................................................................................................................................................................................................................................................................................................................................................................... (21.6s)
[Summary] 3188 tests run (169.8s): 3188 OK, 0 FAILED, 0 SKIPPED
/usr/bin/ld: final link failed: No space left on device
collect2: error: ld returned 1 exit status
Error: execution of an external program failed: 'g++  @eest_engine_test_linkerArgs.txt'

Not sure why this is failing. My changes here shouldn't have increased the disk usage significantly. Is there some caches on the runners that need to be cleaned up?

Actually it looks like the tests are rather large after being unzipped.

@bhartnett bhartnett enabled auto-merge (squash) November 28, 2025 04:06
@bhartnett bhartnett merged commit 66e9119 into master Nov 28, 2025
18 checks passed
@bhartnett bhartnett deleted the fix-eest-engine-tests branch November 28, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhartnett @tersec