Refactor conf with flatten #7761
Conversation
| name: "rest-max-body-size" .}: Natural | ||
|
|
||
| maxHeadersSize* {. | ||
| defaultValue: 128 |
There was a problem hiding this comment.
Note BeaconNodeconf had this set to 64.
| defaultValue: 8008 | ||
| name: "metrics-port" .}: Port | ||
|
|
||
| MetricsBetaConf* = object |
There was a problem hiding this comment.
this exists because of the port difference and the description adding "BETA". But maybe can just use MetricsConf
nitely
force-pushed
the
nitely_conf_flatten_refactor
branch
from
1954583 to
a2846fd
Compare
|
If you going to refactor configs it would be nice if you split all the configs between parts, because when VC builds it imports whole BN codebase just because of the |
| if t.nanoseconds < 0: 0'i64 else: t.nanoseconds)) | ||
|
|
||
| type | ||
| RequestConf* = object |
There was a problem hiding this comment.
Little nit, but if we pack this perhaps the naming should be a bit more clear that this is about REST API configuration settings. RequestConf seems a bit too general.
example: RestRequestConf or RestApiConf ?
4 participants
Changes:
MetricsConfrestRequestTimeout,restMaxRequestBodySize,restMaxRequestHeadersSizeintoRequestConf. But this could be passed individually instead.