fix(backup)_: do not show the backup notifi backup during normal fetch

Fixes status-im/status-desktop#17555

We were adding the Notification of the back ups by accident when creating a normal account (not restored), because I added the code to create the notification in the `RequestAllHistoricMessages` function as well, even though the Messenger already does it. So for normal restores, it probably tried to add it twice, though they have the same ID, so it wasn't noticed

Author: jrainville

protocol/messenger_backup_handler.go

@@ -127,6 +127,10 @@ func (m *Messenger) handleBackup(state *ReceivedMessageState, message *protobuf.
 }
 
 func (m *Messenger) updateBackupFetchProgress(message *protobuf.Backup, response *wakusync.WakuBackedUpDataResponse, state *ReceivedMessageState) error {
+	if m.backedUpFetchingStatus == nil {
+		return nil
+	}
+
 	m.backedUpFetchingStatus.fetchingCompletedMutex.Lock()
 	defer m.backedUpFetchingStatus.fetchingCompletedMutex.Unlock()
 

protocol/messenger_backup_test.go

@@ -417,6 +417,37 @@ func (s *MessengerBackupSuite) TestFetchingDuringBackup() {
 	s.Require().Equal(ActivityCenterNotificationTypeBackupSyncingSuccess, state.Response.ActivityCenterNotifications()[0].Type)
 }
 
+func (s *MessengerBackupSuite) TestBackupWithoutStatusFetching() {
+	bob1 := s.m
+	// Remove the status fetching
+	bob1.backedUpFetchingStatus = nil
+	bob1.config.messengerSignalsHandler = &MessengerSignalsHandlerMock{
+		wakuBackedUpDataResponseChan: make(chan *wakusync.WakuBackedUpDataResponse, 1000),
+	}
+
+	state := ReceivedMessageState{
+		Response: &MessengerResponse{},
+	}
+
+	backup := &protobuf.Backup{
+		Clock: 1,
+		ContactsDetails: &protobuf.FetchingBackedUpDataDetails{
+			DataNumber:  uint32(0),
+			TotalNumber: uint32(1),
+		},
+	}
+
+	err := bob1.HandleBackup(
+		&state,
+		backup,
+		&v1protocol.StatusMessage{},
+	)
+	s.Require().NoError(err)
+	// The backup was handled but nothing was sent to the AC
+	s.Require().Len(state.Response.ActivityCenterNotifications(), 0)
+	s.Require().True(state.Response.BackupHandled)
+}
+
 func (s *MessengerBackupSuite) TestBackupSettings() {
 	s.T().Skip("flaky test")
 	const (

protocol/messenger_mailserver.go

@@ -320,11 +320,6 @@ func (m *Messenger) RequestAllHistoricMessages(forceFetchingBackup, withRetries
 
 	allResponses := &MessengerResponse{}
 	if forceFetchingBackup || !backupFetched {
-		err = m.startBackupFetchingTracking(allResponses)
-		if err != nil {
-			return nil, err
-		}
-
 		m.logger.Info("fetching backup")
 		err := m.syncBackup()
 		if err != nil {