Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📈 Swaps as a New Tab - Trading Section #22035

Open
8 tasks
shivekkhurana opened this issue Feb 7, 2025 · 0 comments
Open
8 tasks

📈 Swaps as a New Tab - Trading Section #22035

shivekkhurana opened this issue Feb 7, 2025 · 0 comments
Labels
feature feature requests wallet-core Issues for mobile wallet team
Milestone

Comments

@shivekkhurana
Copy link
Contributor

shivekkhurana commented Feb 7, 2025

User Story

As a user, I want to expose the swap feature as a new tab in the main App frame so that I can easily access it.

Description

This is the first stage of exposing revenue generating features under the banner of "Trading" tab. For now, trading has swaps, but soon we'll add more components to it.

The new structure of the App tabs will be:

  1. Wallet - is default
  2. Trading (Swaps)
  3. Messenger
  4. Communities

The swap feature will be accessible at the same level as Wallet, Messenger, and Communities.

Acceptance Criteria

  • The swap feature is accessible from the main App frame.
  • The trading tab should have a blue dot (super script) to indicate that this is new.
  • The swap feature is displayed correctly as in the Figma design.
  • The swaps should open with certain defaults: mainnet for chain, weth for receive token and usdt for send token
  • For default account:
    • If we have the last used account in db, use that
    • Else use the account with the most value in it
  • When the swap is complete, the user should be redirected to Trading tab with a toast of the txn. On clicking the toast, the user should be taken to wallet activity.

Notes

@shivekkhurana shivekkhurana added the feature feature requests label Feb 7, 2025
@shivekkhurana shivekkhurana added this to the 2.33.0 milestone Feb 7, 2025
@shivekkhurana shivekkhurana added the wallet-core Issues for mobile wallet team label Feb 7, 2025
@smohamedjavid smohamedjavid removed their assignment Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests wallet-core Issues for mobile wallet team
Projects
Status: Next
Development

No branches or pull requests

2 participants