Skip to content

Commit 0d90e0f

Browse files
committed
build: switch for loops back to while-read loops to avoid argument list limits
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent 2511aed commit 0d90e0f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: tools/make/lib/lint/javascript/eslint.mk

+4-4
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ ifeq ($(FAIL_FAST), true)
9292
done
9393
else
9494
$(QUIET) status=0; \
95-
for file in $$($(FIND_SOURCES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
95+
$(FIND_SOURCES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
9696
echo ''; \
9797
echo "Linting file: $$file"; \
9898
if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file; then \
@@ -133,7 +133,7 @@ ifeq ($(FAIL_FAST), true)
133133
done
134134
else
135135
$(QUIET) status=0; \
136-
for file in $$($(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
136+
$(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
137137
echo ''; \
138138
echo "Linting file: $$file"; \
139139
if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_TESTS) $$file; then \
@@ -174,7 +174,7 @@ ifeq ($(FAIL_FAST), true)
174174
done
175175
else
176176
$(QUIET) status=0; \
177-
for file in $$($(FIND_EXAMPLES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
177+
$(FIND_EXAMPLES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
178178
echo ''; \
179179
echo "Linting file: $$file"; \
180180
if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_EXAMPLES) $$file; then \
@@ -215,7 +215,7 @@ ifeq ($(FAIL_FAST), true)
215215
done
216216
else
217217
$(QUIET) status=0; \
218-
for file in $$($(FIND_BENCHMARKS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]'); do \
218+
$(FIND_BENCHMARKS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
219219
echo ''; \
220220
echo "Linting file: $$file"; \
221221
if ! $(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_BENCHMARKS) $$file; then \

0 commit comments

Comments
 (0)