chore: fix JavaScript lint errors (issue #10528)#10531
chore: fix JavaScript lint errors (issue #10528)#10531DebuggingMax wants to merge 1 commit intostdlib-js:developfrom
Conversation
- Remove unused eslint-disable directives and fix array-element-newline issues in test.marsaglia.js - Replace new Array() constructor with array literal and push in benchmark.js Resolves stdlib-js#10528
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Description
This PR fixes the JavaScript lint errors reported in issue #10528.
Changes
lib/node_modules/@stdlib/stats/kstest/test/test.marsaglia.js
eslint-disable-line array-element-newlinedirectivesexpectedarray to a single line to avoid array-element-newline issueslib/node_modules/@stdlib/utils/pluck/benchmark/benchmark.js
new Array(100)andnew Array(5)constructors with array literals and push operationsRelated Issues
Resolves #10528