Skip to content

Commit 8bae49b

Browse files
committedSep 8, 2023
fix: fixed matchLabels for deployments/services
1 parent a16811e commit 8bae49b

File tree

7 files changed

+25
-7
lines changed

7 files changed

+25
-7
lines changed
 
+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
dependencies:
22
- name: extensionlib
33
repository: https://steadybit.github.io/helm-charts
4-
version: 1.4.3
5-
digest: sha256:8ea2d95f282d0e0e19ead08ff44fdca06a18c130c45f251dd87b1e5256341288
6-
generated: "2023-08-10T07:55:31.707089+02:00"
4+
version: 1.4.4
5+
digest: sha256:b241bfbb60b24ff401a45d75efeaebfd5242801712bfaf7740f0461df9a50c37
6+
generated: "2023-09-07T16:49:31.805556+02:00"

‎charts/steadybit-extension-http/Chart.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v2
22
name: steadybit-extension-http
33
description: Steadybit action implementation to check HTTP endpoints.
4-
version: 1.0.15
4+
version: 1.0.16
55
appVersion: latest
66
home: https://www.steadybit.com/
77
icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png
@@ -21,5 +21,5 @@ annotations:
2121
url: https://hub.steadybit.com
2222
dependencies:
2323
- name: extensionlib
24-
version: ^1.4.3
24+
version: ^1.4.4
2525
repository: https://steadybit.github.io/helm-charts
Binary file not shown.
Binary file not shown.

‎charts/steadybit-extension-http/templates/deployment.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ spec:
1212
replicas: 1
1313
selector:
1414
matchLabels:
15-
app.kubernetes.io/name: {{ include "extensionlib.names.name" . }}
15+
{{- include "extensionlib.selectorLabels" . | nindent 6 }}
1616
template:
1717
metadata:
1818
labels:
19-
app.kubernetes.io/name: {{ include "extensionlib.names.name" . }}
19+
{{- include "extensionlib.selectorLabels" . | nindent 8 }}
2020
{{- include "extensionlib.labels" (list .) | nindent 8 }}
2121
{{- range $key, $value := .Values.extraLabels }}
2222
{{ $key }}: {{ $value }}

‎charts/steadybit-extension-http/tests/__snapshot__/deployment_test.yaml.snap

+14
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,14 @@ manifest should match snapshot using podAnnotations and Labels:
1111
replicas: 1
1212
selector:
1313
matchLabels:
14+
app.kubernetes.io/instance: RELEASE-NAME
1415
app.kubernetes.io/name: steadybit-extension-http
1516
template:
1617
metadata:
1718
annotations:
1819
some-annotation: some-annotation-value
1920
labels:
21+
app.kubernetes.io/instance: RELEASE-NAME
2022
app.kubernetes.io/name: steadybit-extension-http
2123
some-label: some-label-value
2224
steadybit.com/discovery-disabled: "true"
@@ -70,11 +72,13 @@ manifest should match snapshot with TLS:
7072
replicas: 1
7173
selector:
7274
matchLabels:
75+
app.kubernetes.io/instance: RELEASE-NAME
7376
app.kubernetes.io/name: steadybit-extension-http
7477
template:
7578
metadata:
7679
annotations: null
7780
labels:
81+
app.kubernetes.io/instance: RELEASE-NAME
7882
app.kubernetes.io/name: steadybit-extension-http
7983
steadybit.com/discovery-disabled: "true"
8084
spec:
@@ -138,11 +142,13 @@ manifest should match snapshot with extra env vars:
138142
replicas: 1
139143
selector:
140144
matchLabels:
145+
app.kubernetes.io/instance: RELEASE-NAME
141146
app.kubernetes.io/name: steadybit-extension-http
142147
template:
143148
metadata:
144149
annotations: null
145150
labels:
151+
app.kubernetes.io/instance: RELEASE-NAME
146152
app.kubernetes.io/name: steadybit-extension-http
147153
steadybit.com/discovery-disabled: "true"
148154
spec:
@@ -203,11 +209,13 @@ manifest should match snapshot with extra labels:
203209
replicas: 1
204210
selector:
205211
matchLabels:
212+
app.kubernetes.io/instance: RELEASE-NAME
206213
app.kubernetes.io/name: steadybit-extension-http
207214
template:
208215
metadata:
209216
annotations: null
210217
labels:
218+
app.kubernetes.io/instance: RELEASE-NAME
211219
app.kubernetes.io/name: steadybit-extension-http
212220
steadybit.com/discovery-disabled: "true"
213221
tags.datadoghq.com/service: steadybit-extension
@@ -261,11 +269,13 @@ manifest should match snapshot with mutual TLS:
261269
replicas: 1
262270
selector:
263271
matchLabels:
272+
app.kubernetes.io/instance: RELEASE-NAME
264273
app.kubernetes.io/name: steadybit-extension-http
265274
template:
266275
metadata:
267276
annotations: null
268277
labels:
278+
app.kubernetes.io/instance: RELEASE-NAME
269279
app.kubernetes.io/name: steadybit-extension-http
270280
steadybit.com/discovery-disabled: "true"
271281
spec:
@@ -338,11 +348,13 @@ manifest should match snapshot with mutual TLS using containerPaths:
338348
replicas: 1
339349
selector:
340350
matchLabels:
351+
app.kubernetes.io/instance: RELEASE-NAME
341352
app.kubernetes.io/name: steadybit-extension-http
342353
template:
343354
metadata:
344355
annotations: null
345356
labels:
357+
app.kubernetes.io/instance: RELEASE-NAME
346358
app.kubernetes.io/name: steadybit-extension-http
347359
steadybit.com/discovery-disabled: "true"
348360
spec:
@@ -401,11 +413,13 @@ manifest should match snapshot without TLS:
401413
replicas: 1
402414
selector:
403415
matchLabels:
416+
app.kubernetes.io/instance: RELEASE-NAME
404417
app.kubernetes.io/name: steadybit-extension-http
405418
template:
406419
metadata:
407420
annotations: null
408421
labels:
422+
app.kubernetes.io/instance: RELEASE-NAME
409423
app.kubernetes.io/name: steadybit-extension-http
410424
steadybit.com/discovery-disabled: "true"
411425
spec:

‎charts/steadybit-extension-http/tests/__snapshot__/service_test.yaml.snap

+4
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ manifest should match snapshot with TLS:
1515
protocol: TCP
1616
targetPort: 8085
1717
selector:
18+
app.kubernetes.io/instance: RELEASE-NAME
1819
app.kubernetes.io/name: steadybit-extension-http
1920
manifest should match snapshot with mutual TLS:
2021
1: |
@@ -33,6 +34,7 @@ manifest should match snapshot with mutual TLS:
3334
protocol: TCP
3435
targetPort: 8085
3536
selector:
37+
app.kubernetes.io/instance: RELEASE-NAME
3638
app.kubernetes.io/name: steadybit-extension-http
3739
manifest should match snapshot with mutual TLS using containerPaths:
3840
1: |
@@ -51,6 +53,7 @@ manifest should match snapshot with mutual TLS using containerPaths:
5153
protocol: TCP
5254
targetPort: 8085
5355
selector:
56+
app.kubernetes.io/instance: RELEASE-NAME
5457
app.kubernetes.io/name: steadybit-extension-http
5558
manifest should match snapshot without TLS:
5659
1: |
@@ -69,4 +72,5 @@ manifest should match snapshot without TLS:
6972
protocol: TCP
7073
targetPort: 8085
7174
selector:
75+
app.kubernetes.io/instance: RELEASE-NAME
7276
app.kubernetes.io/name: steadybit-extension-http

0 commit comments

Comments
 (0)
Please sign in to comment.