feat: - Use "error" in the expected HTTP status code field to verify that requests are returning an error

Author: ReuDa

exthttpcheck/check.go

@@ -183,8 +183,6 @@ func requestWorker(executionRunData *ExecutionRunData, state *HTTPCheckState, ch
 			}
 
 			responseStatusWasExpected := false
-			responseBodyWasSuccessful := true
-			responseTimeWasSuccessful := true
 
 			req, err := createRequest(state)
 			if err != nil {
@@ -212,17 +210,23 @@ func requestWorker(executionRunData *ExecutionRunData, state *HTTPCheckState, ch
 			if err != nil {
 				log.Error().Err(err).Msg("Failed to execute request")
 				now := time.Now()
+				responseStatusWasExpected = slices.Contains(state.ExpectedStatusCodes, "error")
 				executionRunData.metrics <- action_kit_api.Metric{
 					Metric: map[string]string{
-						"url":   req.URL.String(),
-						"error": err.Error(),
+						"url":                  req.URL.String(),
+						"error":                err.Error(),
+						"expected_http_status": strconv.FormatBool(responseStatusWasExpected),
 					},
 					Name:      extutil.Ptr("response_time"),
 					Value:     float64(now.Sub(started).Milliseconds()),
 					Timestamp: now,
 				}
-				responseStatusWasExpected = slices.Contains(state.ExpectedStatusCodes, "error")
+				if responseStatusWasExpected {
+					executionRunData.requestSuccessCounter.Add(1)
+				}
 			} else {
+				responseBodyWasSuccessful := true
+				responseTimeWasSuccessful := true
 				responseTimeValue := float64(ended.Sub(requestWritten).Milliseconds())
 				log.Debug().Msgf("Got response %s", response.Status)
 				responseStatusWasExpected = slices.Contains(state.ExpectedStatusCodes, strconv.Itoa(response.StatusCode))