Change from wasm32-unknown-unknown
to wasm32v1-none
#1624
leighmcculloch
started this conversation in
Stellar Ecosystem Proposals
Replies: 1 comment 1 reply
-
Awesome news, congrats on the work 👏 Just tried to update my project to latest and all worked except events. But not sure it's linked to precisely that change, sorry for the noise otherwise. CI and all pass on 22.0.3 and fails with 22.0.5. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
🌟 The new
wasm32v1-none
Rust target that @graydon contributed is available for Rust 1.84.Up until now building contracts has required Rust 1.81 or lower because Rust 1.82 shipped changes to the
wasm32-unknown-unknown
target that are incompatible with Soroban.In response @graydon worked with folks in the Rust project to create a new much more stable wasm32 target, named
wasm32v1-none
.Now that the new target is available, we need to coordinate the changes to shift built contracts to the new target.
I believe the following steps required at least:
Sanity check of
rs-soroban-sdk
,rs-soroban-env
,rs-stellar-xdr
, to ensure there are no cfg’s that would select one of the wasm32 targets and not the other. It should be possible to build forwasm32-unknown-unknown
orwasm32v1-none
, butwasm32v1-none
is what contract developers should use. Update CI to test both.Sanity check that
rs-soroban-sdk
with all feature combinations builds onwasm32v1-none
. Update CI to test both.Update
stellar-cli
to build contracts usingwasm32v1-none
when Rust >= 1.84, andwasm32-unknown-unknown
when Rust < 1.84.Update
stellar-docs
to recommend using Rust 1.84+ and installing the new target instead withrustup target install wasm32v1-none
.Update repos using
rust-toolchain.toml
, such assoroban-examples
, to usestable
and the new target:wasm32v1-none
.Does anyone see any other changes that are needed, either within SDF maintained docs and tools, or docs and tools maintained by anyone else?
Beta Was this translation helpful? Give feedback.
All reactions