-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Soroban interface version to getNetwork response #17
Comments
Is it possible for this to be exposed by core? Also another question, will the interface version be able to change independent of the protocol version? @anupsdf |
That would be great. Thanks! |
It looks like #3960 was merged at the end of November, so this issue should be unblocked now. |
@wildework made a similar suggestion that fits well with this one to have
Ref: stellar/stellar-protocol#1476 (comment) Similar to how Horizon already reports the versions available at: "current_protocol_version": 20,
"supported_protocol_version": 20,
"core_supported_protocol_version": 20 Ref: https://horizon.stellar.org/ |
https://github.com/stellar/soroban-tools/blob/967351b064bac431f0d6f9ae61ba6e4f0b417a06/cmd/soroban-rpc/internal/methods/get_network.go#L31C26-L31C26
It would be very useful for the RPC method
getNetwork
to return the Soroban contract interface version alongside everything else it already returns.Being able to fetch what Soroban version is deployed on the network exposed through the RPC would allow for a simple check before trying to deploy a new WASM. Makes the endpoint more useful.
The text was updated successfully, but these errors were encountered: