Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Soroban interface version to getNetwork response #17

Open
wildework opened this issue Oct 15, 2023 · 5 comments
Open

Add Soroban interface version to getNetwork response #17

wildework opened this issue Oct 15, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@wildework
Copy link

https://github.com/stellar/soroban-tools/blob/967351b064bac431f0d6f9ae61ba6e4f0b417a06/cmd/soroban-rpc/internal/methods/get_network.go#L31C26-L31C26

It would be very useful for the RPC method getNetwork to return the Soroban contract interface version alongside everything else it already returns.

Being able to fetch what Soroban version is deployed on the network exposed through the RPC would allow for a simple check before trying to deploy a new WASM. Makes the endpoint more useful.

@wildework wildework changed the title Added Soroban interface version to getNetwork response Add Soroban interface version to getNetwork response Oct 24, 2023
@mollykarcher mollykarcher added the enhancement New feature or request label Oct 31, 2023
@mollykarcher
Copy link
Contributor

mollykarcher commented Oct 31, 2023

Is it possible for this to be exposed by core? Also another question, will the interface version be able to change independent of the protocol version? @anupsdf

@anupsdf
Copy link

anupsdf commented Oct 31, 2023

Is it possible for this to be exposed by core? Also another question, will the interface version be able to change independent of the protocol version? @anupsdf

We have a tracking issue #3960 to provide Soroban network limits to the info endpoint. We can add the contract interface version as well.

@2opremio
Copy link
Contributor

2opremio commented Nov 7, 2023

That would be great. Thanks!

@leighmcculloch
Copy link
Member

It looks like #3960 was merged at the end of November, so this issue should be unblocked now.

@stellarsaur stellarsaur transferred this issue from stellar/stellar-cli Feb 1, 2024
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Backlog in Platform Scrum Mar 27, 2024
@leighmcculloch
Copy link
Member

@wildework made a similar suggestion that fits well with this one to have getNetwork start reporting what versions of the protocol are supported and that are actively in use. I think we can tie that into this issue.

I would be super happy to see the RPC method getNetwork display the range of supported protocol and pre-protocol versions!

Ref: stellar/stellar-protocol#1476 (comment)

Similar to how Horizon already reports the versions available at:

  "current_protocol_version": 20,
  "supported_protocol_version": 20,
  "core_supported_protocol_version": 20

Ref: https://horizon.stellar.org/
Ref: https://horizon-testnet.stellar.org/
Ref: https://horizon-futurenet.stellar.org/

@mollykarcher mollykarcher moved this from Backlog to To Do in Platform Scrum Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

5 participants