Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xdr2json to a more non-rpc user friendly location #350

Open
chowbao opened this issue Jan 24, 2025 · 2 comments
Open

Move xdr2json to a more non-rpc user friendly location #350

chowbao opened this issue Jan 24, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request rpc-sdk-scrum

Comments

@chowbao
Copy link
Contributor

chowbao commented Jan 24, 2025

xdr2json is currently embedded within stellar-rpc/internal. But this xdr2json might be the only existing golang xdr2json representation. It would be nice to either

  • Move xdr2json to a higher level directory (closer to main/)
  • Or separate out into it's own library/repo
  • Or some other option that is not leaving it embedded in the stellar-rpc application

https://github.com/chowbao/go-stellar-xdr-json
Example separate library/repo where all the rust is precompiled so other golang projects can import xdr2json without the cgo targets. They only need to import "github.com/chowbao/go-stellar-xdr-json/xdr2json"

The precompiled rust looks good for a first pass
TODO:

  • Create a new stellar/go-stellar-xdr-json repo (public)
  • Add github actions/workflow to automatically compile and commit the rust object files
  • If possible also automate the pulling of new releases from the stellar/rs-stellar-xdr
@chowbao
Copy link
Contributor Author

chowbao commented Jan 24, 2025

They're is favor in moving this to it's own repo from this slack thread

@chowbao
Copy link
Contributor Author

chowbao commented Feb 3, 2025

New repo and initial code committed https://github.com/stellar/go-stellar-xdr-json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rpc-sdk-scrum
Projects
Status: To Do
Development

No branches or pull requests

1 participant