Missing ImagePullSecret in deployment.yaml

[ggomez97]

Describe the problem/challenge you have

I have created a Docker image to add some PDF exporting customization files and upload it to docker hub.
So when I deploy the helm pointing to the new image, i want to use the chart value ImagePullSecret [] to load credentials and it fails to load it.

The ImagePullSecret [] is in the example values.yaml, but it is not in the deployment.yaml, so it never gets loaded

Describe the solution you'd like
I would like the chart to get updated to use an ImagePullSecret as helm parameter

Repo values.yaml

My values:

The repo deployement.yaml:
https://github.com/stellarhosted/helm-charts/blob/main/charts/bookstack/templates/deployment.yaml

Anything else you would like to add:
Also, it would be awesome to create the secret of the docker-registry from the helm too.

Environment:

• helm version (use helm version): 3.18.0
• helm chart version and app version: 1.6.1
  • helm2 (use helm list):
  • helm3 (use helm list -n <YOUR NAMESPACE>):

• Kubernetes version (use kubectl version): 1.32.2
• Kubernetes installer & version: Kubeadm 1.32.3
• Cloud provider or hardware configuration: vSphere
• OS (e.g. from /etc/os-release): Rocky-9