Revert "Pretty sure ord() is faster than pack('C', <int>);"

stephen-hill · stephen-hill · commit a028350d039c · 2015-07-08T21:20:17.000+01:00
This reverts commit 951d591.
diff --git a/src/GMPService.php b/src/GMPService.php
@@ -139,7 +139,7 @@ public function decode($base58)
         $output = '';
         while (gmp_cmp($decimal, 0) > 0) {
             list($decimal, $byte) = gmp_div_qr($decimal, 256);
-            $output = ord(gmp_intval($byte)) . $output;
+            $output = pack('C', gmp_intval($byte)) . $output;
         }
 
         // Now we need to add leading zeros

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function decode($base58)`
`139`	`139`	`$output = '';`
`140`	`140`	`while (gmp_cmp($decimal, 0) > 0) {`
`141`	`141`	`list($decimal, $byte) = gmp_div_qr($decimal, 256);`
`142`		`- $output = ord(gmp_intval($byte)) . $output;`
	`142`	`+ $output = pack('C', gmp_intval($byte)) . $output;`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`// Now we need to add leading zeros`