-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #7
Comments
One more note about namespaceing. I remember, you wish to have simple math functions accessible. My proposal is (two parts):
Then:
=> all should be happy |
Sure thing! |
I think we have agreement about principal questions. Can i help somehow more to land changes into master? |
Dear puzrin, I am not able to keep track of activity on my git account. |
@stg consider create organization, transfer project there and add me as second admin of org. Then i'll be able to curate development until your situation changes back. If i do fork, that will look Also, if you like to keep existing code as single-file-based, we could create second repo Let me know what do you think, or if i misunderstand something. |
In continue of #6 (comment) and below
See proposal draft for v2.0.0: https://github.com/speedcontrols/dc_sc_grinder/tree/dev/lib/SYLT-FFT
Goal: simplify use of
SYLT-FFT
as library.Renamed files/folders
test/
folder later)May be
include/sylt-fft/
instead ofinclude
? See etl for example.Added lib namespace prefixes (incomplete)
Example: https://github.com/speedcontrols/dc_sc_grinder/blob/dev/lib/SYLT-FFT/include/config.h#L24
SYLT_FFT_
(too long). May beSYLT_
? What "sylt" means?Redeclared sine table
https://github.com/speedcontrols/dc_sc_grinder/blob/dev/lib/SYLT-FFT/include/config.h#L46-L82
Added #ifdef guards (incomplete)
https://github.com/speedcontrols/dc_sc_grinder/blob/dev/lib/SYLT-FFT/include/config.h#L48
That allows to configure everything via
-D
, no need to edit config manually (+ need prefixes to avoid collisions).Suppressed arch warnings
https://github.com/speedcontrols/dc_sc_grinder/blob/dev/lib/SYLT-FFT/include/intrinsics.h#L12
Hided warnings behind debug guard. If user use this lib with < M4 - no need to annoy on every build.
Notes:
1.0.0
to last commit. That will help users to access "previous" version, and creatingCHANGELOG.md
.SYLT_FFT_
?SYLT_
? Other?What do you think? Can you propagate acceptable changes to upstream?
PS. I'm ~ software architect, but NOT C programmer. So, i'd prefer to not intrude to your code via PRs, without experience of C specifics. But i can prepare samples/descriptions of proposals and other things (except coding).
The text was updated successfully, but these errors were encountered: