Merge pull request #90 from qlemaire22:fix-bug-statistics

robertvanhoesel · web-flow · commit 76eb88d40f9d · 2024-02-27T15:27:28.000+01:00
Player's statistics: remove faction fallback
diff --git a/src/pages/players/[id]-[username]/statistics.astro b/src/pages/players/[id]-[username]/statistics.astro
@@ -41,7 +41,7 @@ const leaderboardEntries = player?.leaderboard_entries
   .sort((a, b) => (b.points ?? 0) - (a.points ?? 0))
 
 const faction = new URLSearchParams(Astro.url.search).get("faction") || leaderboardEntries?.[0].race
-const leaderboard = leaderboardEntries.find((leaderboard) => leaderboard.race === faction) || leaderboardEntries?.[0]
+const leaderboard = leaderboardEntries.find((leaderboard) => leaderboard.race === faction) || null
 
 let leaderboardHistory: LeaderboardEntryHistoryRow[] = []
 
@@ -67,7 +67,7 @@ for (const entry of leaderboardHistory) {
 }
 
 const today = new Date().toISOString().slice(0, 10)
-if (dateLabels[dateLabels.length - 1] !== today) {
+if (dateLabels[dateLabels.length - 1] !== today && leaderboard) {
   dateLabels.push(today)
   mmrEntries.push(Math.round(leaderboard.mmr))
 }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ const leaderboardEntries = player?.leaderboard_entries`
`41`	`41`	`.sort((a, b) => (b.points ?? 0) - (a.points ?? 0))`
`42`	`42`
`43`	`43`	`const faction = new URLSearchParams(Astro.url.search).get("faction") \|\| leaderboardEntries?.[0].race`
`44`		`-const leaderboard = leaderboardEntries.find((leaderboard) => leaderboard.race === faction) \|\| leaderboardEntries?.[0]`
	`44`	`+const leaderboard = leaderboardEntries.find((leaderboard) => leaderboard.race === faction) \|\| null`
`45`	`45`
`46`	`46`	`let leaderboardHistory: LeaderboardEntryHistoryRow[] = []`
`47`	`47`
`@@ -67,7 +67,7 @@ for (const entry of leaderboardHistory) {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`const today = new Date().toISOString().slice(0, 10)`
`70`		`-if (dateLabels[dateLabels.length - 1] !== today) {`
	`70`	`+if (dateLabels[dateLabels.length - 1] !== today && leaderboard) {`
`71`	`71`	`dateLabels.push(today)`
`72`	`72`	`mmrEntries.push(Math.round(leaderboard.mmr))`
`73`	`73`	`}`