Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryblokStory and StoryblokServerComponent don't support passing down arbitrary props anymore #1302

Closed
1 task done
TomRadford opened this issue Dec 17, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
pending-author [Issue] Awaiting further information or action from the issue author released

Comments

@TomRadford
Copy link

Describe the issue you're facing

In "@storyblok/react": "4.0.0" in NextJS 15 we were able to pass down arbitary props down to pages/blocks like so:

  <StoryblokServerComponent // or StoryblokStory
            blok={footerData.story.content}
            // any prop what will get passed down:
            backgroundVariant={data.story.content.background_variant}
            browser={browser}
            {...anyOtherProp}
/>

in 4.2.1 this yields TS errors:
image

Reproduction

.

Steps to reproduce

No response

System Info

"react": "19.0.0",
"react-dom": "19.0.0",
"@storyblok/react": "^4.2.1",
"next": "15.1.0",

  System:
    OS: macOS 14.3
    CPU: (8) arm64 Apple M3
    Memory: 87.33 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.10.0 - ~/.local/state/fnm_multishells/54467_1734429279113/bin/node
    npm: 10.9.0 - ~/.local/state/fnm_multishells/54467_1734429279113/bin/npm
    pnpm: 9.12.3 - ~/.local/state/fnm_multishells/54467_1734429279113/bin/pnpm
  Browsers:
    Chrome: 131.0.6778.140
    Safari: 17.3

Used Package Manager

pnpm

Error logs (Optional)

No response

Validations

@TomRadford TomRadford added pending-author [Issue] Awaiting further information or action from the issue author pending-triage [Issue] Ticket is pending to be prioritised labels Dec 17, 2024
@TomRadford TomRadford changed the title StoryblokStory and StoryblokServerComponent don't support passing down arbitrary props StoryblokStory and StoryblokServerComponent don't support passing down arbitrary props anymore Dec 17, 2024
@edodusi
Copy link
Contributor

edodusi commented Dec 17, 2024

@TomRadford we have just fixed this in 4.3.1 (#1296)

@edodusi edodusi self-assigned this Dec 17, 2024
@edodusi edodusi added released and removed pending-triage [Issue] Ticket is pending to be prioritised labels Dec 17, 2024
@TomRadford
Copy link
Author

Amazing! Thanks @edodusi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-author [Issue] Awaiting further information or action from the issue author released
Projects
None yet
Development

No branches or pull requests

2 participants