Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rfc] move from axios to fetch + polyfill #15

Closed
csenio opened this issue Mar 31, 2020 · 3 comments
Closed

[rfc] move from axios to fetch + polyfill #15

csenio opened this issue Mar 31, 2020 · 3 comments

Comments

@csenio
Copy link
Contributor

csenio commented Mar 31, 2020 •
edited
Loading

why

  • fetch can do anything Axios can
  • fetch is a browser standard
  • can be polyfilled via unfetch (500b instead of 4.4kb gziped)
@csenio csenio changed the title move from axios to fetch + polyfill [rfc] move from axios to fetch + polyfill Mar 31, 2020
@mitchelvanbever
Copy link
Member

I'm very much down for this :)

I would also like to opt for SWR as well!

@csenio
Copy link
Contributor Author

csenio commented Apr 1, 2020

SWR is already in there, maybe we should add some examples of when/how to use it?

@BJvdA
Copy link
Member

BJvdA commented Apr 3, 2020

only remark I have is polyfilling for abortcontroller but it's an edge case

I have used the CancelToken in axios before for example in search components

@csenio csenio closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BJvdA @mitchelvanbever @csenio